:RDKEMW-6929 : Westeros refactoring#423
Open
sajnanazeer wants to merge 1 commit into
Open
Conversation
Reason for change : Modiying recipes for westeros. Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com RDKEMW-6929 : Westeros refactoring Reason for change : Modiying recipes for westeros. Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com RDKEMW-6929 : Westeros refactoring Reason for change : Modiying recipes for westeros. Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com RDKEMW-8961: Integration of refactored Westeros into RDKE builds Reason for change : Modiying recipes for westeros. Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com RDKEMW-8961: Integration of refactored Westeros into RDKE builds Reason for change : Modiying recipes for westeros. Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com RDKEMW-8961: Integration of refactored Westeros into RDKE builds Reason for change : Modiying recipes for westeros. Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com RDKEMW-8961: Integration of refactored Westeros into RDKE builds Reason for change : Modiying recipes for westeros. Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com RDKEMW-8961: Integration of refactored Westeros into RDKE builds Reason for change : Modiying recipes for westeros. Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com RDKEVD-4868: [TV] Update Westeros to 1.01.63 in RDKE Reason for change : Bring ermgr with essosresmgr lib to VL build Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com Move to version 1.01.63 RDKEVD-4868: [TV] Update Westeros to 1.01.63 in RDKE Reason for change : Change : Fixing build issue Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com Update Westeros to 2.0.0 Update westeros to 2.0.0 RDKEVD-4868 : Westeros Upgrade to 2.0.0 Reason for change : Modiying recipes for westeros 2.1.1 Test Procedure : None Priority : P1 Risks : None Signed-off-by : Sajna_NazeerK@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Westeros/Essos Yocto recipes to fetch sources from upstream GitHub repos and align recipe structure (SUMMARY ordering, SRC_URI placement), while adding some packaging/install adjustments.
Changes:
- Switch Westeros/Essos source URIs (and revisions) to rdkcentral GitHub repos via variables in
westeros.inc. - Reorder/clean up
SUMMARYandinclude westeros.incusage across Westeros recipes. - Add header installation into
${includedir}forwesteros.bband expand Essos packaging/dependency metadata.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-graphics/westeros/westeros.inc | Centralizes upstream URIs/SRCREVs and license defaults for Westeros-related recipes. |
| recipes-graphics/westeros/westeros.bb | Uses centralized URI and adds header installation into the -dev package. |
| recipes-graphics/westeros/westeros-simpleshell.bb | Uses centralized URI and fixes SUMMARY spelling/ordering. |
| recipes-graphics/westeros/westeros-simplebuffer.bb | Uses centralized URI and fixes SUMMARY spelling/ordering. |
| recipes-graphics/westeros/essos.bb | Switches to standalone Essos GitHub fetch and adds new deps/packaging settings. |
Comments suppressed due to low confidence (1)
recipes-graphics/westeros/westeros.inc:11
SRCREV_westeros-sinkis not a valid BitBake variable name because of the-character; this is likely to cause a parse error (or at minimum prevents the namedSRCREV_<name>mechanism from working). Rename thename=(e.g.,name=westeros_sink) and the correspondingSRCREV_...variable to use only[A-Za-z0-9_]characters.
#For westeros-sink
WESTEROS_SINK_URI ?= "git://github.com/rdkcentral/westeros-sink;protocol=https;nobranch=1;name=westeros-sink"
SRCREV_westeros-sink ?= "2.1.1"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change : Modiying recipes for westeros.
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
RDKEMW-6929 : Westeros refactoring
Reason for change : Modiying recipes for westeros.
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
RDKEMW-6929 : Westeros refactoring
Reason for change : Modiying recipes for westeros.
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
RDKEMW-8961: Integration of refactored Westeros into RDKE builds
Reason for change : Modiying recipes for westeros.
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
RDKEMW-8961: Integration of refactored Westeros into RDKE builds
Reason for change : Modiying recipes for westeros.
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
RDKEMW-8961: Integration of refactored Westeros into RDKE builds
Reason for change : Modiying recipes for westeros.
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
RDKEMW-8961: Integration of refactored Westeros into RDKE builds
Reason for change : Modiying recipes for westeros.
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
RDKEMW-8961: Integration of refactored Westeros into RDKE builds
Reason for change : Modiying recipes for westeros.
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
RDKEVD-4868: [TV] Update Westeros to 1.01.63 in RDKE
Reason for change : Bring ermgr with essosresmgr lib to VL build
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
Move to version 1.01.63
RDKEVD-4868: [TV] Update Westeros to 1.01.63 in RDKE
Reason for change : Change : Fixing build issue
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com
Update Westeros to 2.0.0
Update westeros to 2.0.0
RDKEVD-4868 : Westeros Upgrade to 2.0.0
Reason for change : Modiying recipes for westeros 2.1.1
Test Procedure : None
Priority : P1
Risks : None
Signed-off-by : Sajna_NazeerK@comcast.com