Skip to content

RDKEVD-5128: Changing the PR and PN for benchmarking tool#436

Open
Chirag-BN wants to merge 2 commits into
developfrom
feature/RDKEVD-5128
Open

RDKEVD-5128: Changing the PR and PN for benchmarking tool#436
Chirag-BN wants to merge 2 commits into
developfrom
feature/RDKEVD-5128

Conversation

@Chirag-BN
Copy link
Copy Markdown

Change-Id: I63efb3ed24168c9e68e38ab0d178696ae3344f27

Copilot AI review requested due to automatic review settings May 15, 2026 14:05
@Chirag-BN Chirag-BN requested review from a team as code owners May 15, 2026 14:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds PACKAGE_ARCH overrides for two benchmarking-related OSS recipes (vkmark and assimp) so they are built against the OSS layer architecture. The PR title indicates it changes the PR/PN entries used by the benchmarking tooling.

Changes:

  • Add PACKAGE_ARCH:pn-vkmark set to ${OSS_LAYER_ARCH}.
  • Add PACKAGE_ARCH:pn-assimp set to ${OSS_LAYER_ARCH}.
Comments suppressed due to low confidence (1)

conf/include/package_revisions_oss.inc:951

  • These two new PACKAGE_ARCH entries are inserted between the alphabetically-ordered top section (ending at zstd) and the "Package revision for OSS modules that are built and released by other layers" section. Both vkmark and assimp already have their PR:pn-* entries within that lower "other layers" section (lines 955 and 985), so the corresponding PACKAGE_ARCH lines would be more consistent if grouped alongside them rather than placed in this stranded block. Additionally, vkmark appears before assimp, which breaks the alphabetical ordering used everywhere else in the file.
PACKAGE_ARCH:pn-vkmark = "${OSS_LAYER_ARCH}"

PACKAGE_ARCH:pn-assimp = "${OSS_LAYER_ARCH}"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread conf/include/package_revisions_oss.inc Outdated
Comment on lines +949 to +951
PACKAGE_ARCH:pn-vkmark = "${OSS_LAYER_ARCH}"

PACKAGE_ARCH:pn-assimp = "${OSS_LAYER_ARCH}"
Change-Id: I63efb3ed24168c9e68e38ab0d178696ae3344f27
@Chirag-BN Chirag-BN force-pushed the feature/RDKEVD-5128 branch from 53db1be to a2d1d47 Compare May 15, 2026 15:18
@github-actions
Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants