Conversation
Reason for the change: Configured systemd PREFERRED version to 1:250 Backport tar_1.17 recipe which is gplv2 licenced required for building systemd v250 Backport systemd v250 changes for RDKE Signed-off-by: mselva006c <mani_selvaraj@comcast.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Reason for the change: Remove reference to default-time-setter.sh script in systemd-timesyncd to fix the build error.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the OSS layer’s build configuration to prefer systemd v250 and adjusts the systemd v250 bbappend behavior/configuration. It also introduces a tar 1.17 recipe (with several patches) and pins tar’s OSS package arch/revision settings.
Changes:
- Set
PREFERRED_VERSION_systemdto1:250%in the OSS package revisions include. - Update
systemd_250.%.bbappendto adjust patch set and post-install configuration (timesyncd NTP, journald sizing, dependency/package tweaks). - Add a tar 1.17 recipe (
tar.inc+tar_1.17.bb) and patch set, plus tar arch/revision entries.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-extended/tar/tar/0001-lib-argp-parse.c-Fix-compiler-error.patch | Adds a tar 1.17 patch to address a format-security compiler error. |
| recipes-extended/tar/tar.inc | Introduces shared tar recipe include (install + alternatives + packaging). |
| recipes-extended/tar/tar-1.17/m4extensions.patch | Adds autoconf-related fix for tar 1.17. |
| recipes-extended/tar/tar-1.17/gcc43build.patch | Adds GCC inline-related compatibility patch for tar 1.17. |
| recipes-extended/tar/tar-1.17/avoid_heap_overflow.patch | Adds CVE-related heap overflow mitigation patch for tar 1.17. |
| recipes-extended/tar/tar_1.17.bb | Adds the tar 1.17 recipe wiring in the patch set and checksums. |
| recipes-core/systemd/systemd_250.%.bbappend | Updates systemd v250 append behavior (patch list, NTP/journald config, deps, package content changes). |
| conf/include/package_revisions_oss.inc | Pins preferred systemd version and adds tar PR/PACKAGE_ARCH entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+120
to
124
| #Remove volatile bind dependency as it is not an oss delivered component | ||
| RDEPENDS:${PN}:remove = "volatile-binds" | ||
|
|
||
| EXTRA_OECONF += "--disable-ldconfig" | ||
| EXTRA_OECONF:append:libc-uclibc = " --disable-sysusers --disable-machined " |
Comment on lines
+39
to
+41
| #Configure NTP server (time.google.com) in timesyncd.conf | ||
| if [ -n "${@bb.utils.contains('PACKAGECONFIG', 'timesyncd', 'timesyncd', '', d)}" ]; then | ||
| sed -i -e 's/^#NTP=.*/NTP=ntp.ccp.xcal.tv/g' ${D}${sysconfdir}/systemd/timesyncd.conf | ||
| sed -i -e 's/^#NTP=.*/NTP=time.google.com/g' ${D}${sysconfdir}/systemd/timesyncd.conf |
| fi | ||
|
|
||
| if ${@bb.utils.contains('DISTRO_FEATURES', 'syslog-ng', 'false', 'true', d)}; then | ||
| #Journal conf overide |
|
|
||
| do_install:append() { | ||
| if ${@bb.utils.contains('DISTRO_FEATURES', 'syslog-ng', 'false', 'true', d)}; then | ||
| #Journal conf overide |
| PREFERRED_VERSION_nativesdk-libdrm = "2.4.110" | ||
| PREFERRED_VERSION_sed = "4.1.2" | ||
|
|
||
| PREFERRED_VERSION_systemd = "1:250%" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for the change: Upgrading systemd PREFERRED version to 1:250
Risk : Low