Rebase to develop#211
Open
Sonajeya31 wants to merge 359 commits into
Open
Conversation
RDK-59966 : Bring the required changes to build RDKB stack Reason for change: Update rdkb.inc with all broadband related variables Update rdk.conf to remove unused setting which is causing failure in broadband Update the components to build RDKB without disturbing client profiles Update setup-environment to support poky Update bblayers.conf.sample to support poky and RDKB layers Update webconfig-framework to include the changes required for RDKB. Update cimplog for RDKB requirement Note: rdkb.inc should be reviewed and cleaned up properly after all the required layers are migrated. Bring in required recipes for RDKB to build which are not OE components. Changes are mostly for broadband without affecting the current client profiles.
* Add GitHub issue template with DoD checklist - Added middleware_change_request.yml issue template - Includes Definition of Done checklist with Status as first column - Status options: Not Started, Done, Not Applicable - Supports multiline items using <br> tags - Tracks middleware component changes, dependencies, and layer tags * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add GitHub issue template with DoD checklist - Added middleware_change_request.yml issue template - Includes Definition of Done checklist with Status as first column - Status options: Not Started, Done, Not Applicable - Supports multiline items using <br> tags - Tracks middleware component changes, dependencies, and layer tags * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Simplify status dropdown in middleware change request template - Remove 'Not Started' text from status column - Replace with simple Yes/No/NA options - Remove status options legend for cleaner UI --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Replace dropdown status fields with checkbox format - Combine status selection and details into paired fields - Make all fields optional for better user experience - Improve placeholder text for clarity
* Simplify status fields in middleware change request template - Replace dropdown status fields with checkbox format - Combine status selection and details into paired fields - Make all fields optional for better user experience - Improve placeholder text for clarity * Further simplify checkbox labels in middleware template - Move DoD item descriptions directly into checkbox labels - Remove redundant label fields for cleaner format - Create more intuitive checklist-style interface
* Simplify status fields in middleware change request template - Replace dropdown status fields with checkbox format - Combine status selection and details into paired fields - Make all fields optional for better user experience - Improve placeholder text for clarity * Further simplify checkbox labels in middleware template - Move DoD item descriptions directly into checkbox labels - Remove redundant label fields for cleaner format - Create more intuitive checklist-style interface * Remove field labels for cleaner form appearance - Add empty label fields to checkboxes and inputs - Creates minimal, streamlined form interface - Checkbox labels and placeholders provide all necessary context
…dance (#385) * Add DoD section description and proprietary information warning * Add compact version of middleware change request template * Update middleware_change_request_compact.yml Updated name * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…D checklist (#387) * Replace checkbox/input fields with single textarea for DoD checklist and remove compact template * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/middleware_change_request.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RDKEMW-10710 : Move breakpad recipe to meta-rdk layer
RDKEMW-10417 : Move common_utils recipe to meta-rdk layer
…ited RDKEMW-16534: Update dobby SRCREV to set swap unlimited by default
RDKEMW-12824: Update dobby SRCREV
RDKEMW-17764: Update Dobby to v3.18.0
Comment on lines
+9
to
+21
| # SRC_URI = "git://github.com/TeknoVenus/ProcessMonitor.git;branch=main" | ||
| SRC_URI = "git://github.com/gomathishankar37/ProcessMonitor.git;protocol=https;branch=exit-handler" | ||
|
|
||
| SRC_URI:append = " file://process-monitor.path \ | ||
| file://process-monitor.service \ | ||
| " | ||
|
|
||
| inherit cmake systemd | ||
|
|
||
| EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release" | ||
|
|
||
| # SRCREV = "63c19611d52cec3331bc9ea1bc82175f5d8a9c96" | ||
| SRCREV = "${AUTOREV}" |
Comment on lines
+462
to
+466
| + struct timeval rcv_timeout = { | ||
| + .tv_sec = SERVICE_MODE_SOCKET_TIMEOUT_MS/1000, | ||
| + .tv_usec = (SERVICE_MODE_SELECT_TIMEOUT_MS%1000)*1000 | ||
| + }; | ||
| + setsockopt(cd, SOL_SOCKET, SO_RCVTIMEO, &rcv_timeout, sizeof(rcv_timeout)); |
| EXTRA_OECONF:append = " --enable-iarmbusSupport=yes" | ||
| EXTRA_OECONF:append = " --enable-iarmbusSupport=yes --enable-t2api=yes" | ||
|
|
||
| EXTRA_OEMAKE += "LIBS='-lsafec'" |
| EXTRA_OECONF:append = " --enable-iarmbus=yes --enable-tr69hostif=yes" | ||
| EXTRA_OECONF:append:client = " --enable-iarmbus=yes --enable-tr69hostif=yes" | ||
| EXTRA_OECONF:append:broadband = " --enable-rdkb=yes --enable-tr181set=yes" | ||
| EXTRA_OEMAKE += "LIBS='-lsafec'" |
|
|
||
| RDEPENDS:${PN} += "systimemgrfactory" | ||
|
|
||
| EXTRA_OECONF = "--enable-t2api=yes" |
Comment on lines
+8
to
10
| DEPENDS = "dbus ${BLUEZ} rdk-logger telemetry" | ||
| DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}" | ||
| DEPENDS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'gdbus_bluez5', 'glib-2.0-native', '', d)}" |
Comment on lines
+18
to
+24
| "name": "test", | ||
| "enabled": true, | ||
| "status": "Up", | ||
| "InitialRunLevel": 5, | ||
| "CurrentRunLevel": 5, | ||
| "id": 2, | ||
| "packager": "local-tarball" |
Comment on lines
+19
to
+23
|
|
||
| # SRCREV = "63c19611d52cec3331bc9ea1bc82175f5d8a9c96" | ||
| SRCREV = "${AUTOREV}" | ||
| PV = "1.0.0" | ||
| PR = "r0" |
Comment on lines
+65
to
+67
| #Do only for brodband | ||
| if [ "$DEVICE_TYPE" = "broadband" ];then | ||
| log_info "Creating destination directory: $(dirname "$DST_BIN")" |
Comment on lines
+4
to
+8
|
|
||
| SRCREV = "${AUTOREV}" | ||
|
|
||
| SRC_URI += "file://bleadvhci.service" | ||
| SRC_URI += "file://bleadvhci.path" |
| SYSTEMD_SERVICE:${PN} += "dcmd.service" | ||
| inherit breakpad-wrapper | ||
| DEPENDS += "breakpad breakpad-wrapper" | ||
| BREAKPAD_BIN:append = "logupload" |
RDKEMW-18969: Update bluetooth components to latest for gaming change…
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 114 out of 114 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
recipes-support/xmidt-agent/xmidt-agent_git.bb:12
PVis set to 1.0.0 but the fetched artifact/version is controlled byPKG_VERSION = 0.5.15and the URL points to v0.5.15. This makes the produced package version misleading and can break upgrade/downgrade semantics. Consider settingPVfromPKG_VERSION(or renamingPKG_VERSIONtoPV) so the recipe version matches the downloaded release.
Comment on lines
7
to
11
|
|
||
| DEPENDS = "dbus ${BLUEZ} rdk-logger" | ||
| DEPENDS = "dbus ${BLUEZ} rdk-logger telemetry" | ||
| DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}" | ||
| DEPENDS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'gdbus_bluez5', 'glib-2.0-native', '', d)}" | ||
|
|
Comment on lines
+21
to
+22
| -I=${libdir}/glib-2.0/include \ | ||
| -I=${includedir}/glib-2.0 \ |
| @@ -0,0 +1,38 @@ | |||
| SUMMARY = "Process Moniter utility and runner service" | |||
| SYSTEMD_SERVICE:${PN} += "dcmd.service" | ||
| inherit breakpad-wrapper | ||
| DEPENDS += "breakpad breakpad-wrapper" | ||
| BREAKPAD_BIN:append = "logupload" |
Comment on lines
14
to
18
| PACKAGE_ARCH = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| CFLAGS:append:broadband += " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', '-DFEATURE_SUPPORT_ONBOARD_LOGGING',d)}" | ||
|
|
||
| S = "${WORKDIR}/git" |
Comment on lines
+18
to
+23
| EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release" | ||
|
|
||
| # SRCREV = "63c19611d52cec3331bc9ea1bc82175f5d8a9c96" | ||
| SRCREV = "${AUTOREV}" | ||
| PV = "1.0.0" | ||
| PR = "r0" |
RDKEMW-19074 : Meminsight csv files fail to get uploaded at configure
RDKEMW-18230: Create vdevice manifest with middleware compontents
|
|
||
| EXTRA_OEMAKE += "LIBS='-lsafec'" | ||
|
|
||
| DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}" |
| EXTRA_OECONF:append:broadband = " --enable-rdkb=yes --enable-tr181set=yes" | ||
| EXTRA_OEMAKE += "LIBS='-lsafec'" | ||
|
|
||
| DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}" |
| ########################################################################## | ||
|
|
||
| [Unit] | ||
| Description=Process Moniter |
Comment on lines
+30
to
+40
| # Check if text matches the pattern <TICKETID>-<ticketno.>[, <TICKETID>-<ticketno.>] : <desc> | ||
| if [[ ! "$text" =~ ^([A-Z0-9]+-[0-9]+)([[:space:]]*,[[:space:]]*[A-Z0-9]+-[0-9]+)*[[:space:]]*:[[:space:]]*.+ ]]; then | ||
| echo "ERROR: $field_name format is invalid." | ||
| echo "Expected format: <TICKETID>-<ticketno.>[, <TICKETID>-<ticketno.>] : <description>" | ||
| echo "Example (single): RDKEMW-123 : Fix playbook issue" | ||
| echo "Example (multiple): RDKEMW-123, RDKDEV-45 : Fix playbook issue" | ||
| echo "" | ||
| echo "Valid ticket IDs are:" | ||
| printf "%s\n" "${VALID_TICKET_IDS[@]}" | ||
| return 1 | ||
| fi |
RDKEMW-19370 : Integrate RFC 1.2.6 Release for RDKE Devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.