rebase#560
Conversation
Reason for change: Upgrade RBUS to 2.11.0 which has Coverity Fixes for rtMessage/rbus Test Procedure: Tested and verified Priority: P1 Risks: Medium
Reason for change: The clang compiler is required for the secclient-rs module. This commit integrates the meta-clang recipe, which provides compiler version 1.72.0. Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com>
Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com>
…Firmware Updates (#512)
RDK-59919 : [RDKE] Port Ops Support Upload Scripts to Source code
… topic/RDKEMW-10995-dev
There was a problem hiding this comment.
Pull request overview
This PR updates multiple BitBake recipe files as part of a rebase operation, updating git commit references (SRCREV) and package versions across several RDK middleware components. The changes include routine version bumps for five recipes and a major refactoring of the crashupload recipe to support new build configurations.
Changes:
- Updated SRCREV and versions for commonutilities (1.5.0→1.5.1), telemetry (1.7.4→1.8.0), rfc (1.2.1 with PR bump), rbus (2.9.0→2.11.0), and dcmd (2.0.0→2.0.3)
- Major refactoring of crashupload recipe (1.0.7→2.0.0) with new source structure, client-specific builds, and additional dependencies
- Added meta-clang layer support to bblayers.conf.sample
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| recipes-common/utils/commonutilities_git.bb | Updated SRCREV and bumped version from 1.5.0 to 1.5.1 with PR increment |
| recipes-common/telemetry/telemetry_git.bb | Updated SRCREV and bumped version from 1.7.4 to 1.8.0 |
| recipes-common/rfc/rfc_git.bb | Updated SRCREV and incremented PR from r0 to r1 |
| recipes-common/rbus/rbus.bb | Updated SRCREV and bumped version from 2.9.0 to 2.11.0 |
| recipes-common/dcmd/dcmd.bb | Updated SRCREV and bumped version from 2.0.0 to 2.0.3 |
| recipes-common/crashupload/crashupload_git.bb | Major refactoring: version 2.0.0, new source structure, client-specific support, additional dependencies |
| conf/template/bblayers.conf.sample | Added conditional inclusion of meta-clang layer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PV = "1.5.0" | ||
| PR = "r0" | ||
| PV = "1.5.1" | ||
| PR = "r1" |
There was a problem hiding this comment.
When PV (package version) is updated, PR (package revision) should typically be reset to "r0". Here PV changed from 1.5.0 to 1.5.1, but PR was incremented to "r1" instead of being reset to "r0". This is inconsistent with the pattern used in other files in this PR (telemetry, rbus, dcmd, crashupload) where PR is reset to "r0" when PV changes.
| PR = "r1" | |
| PR = "r0" |
RDKEMW-13838: Dobby 3.16.1 Release Integration
Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CFLAGS:append = " \ | ||
| -I=${libdir}/glib-2.0/include \ | ||
| -I=${includedir}/glib-2.0 \ | ||
| -DRFC_API_ENABLED \ | ||
| -DT2_EVENT_ENABLED \ | ||
| -DRDK_LOGGER \ | ||
| -DUSE_EXTENDED_LOGGER_INIT \ | ||
| " | ||
|
|
||
| export GLIBS = "-lglib-2.0 -lz" | ||
| export USE_DBUS = "y" | ||
|
|
||
| LDFLAGS += "-Wl,-O1" | ||
| LDFLAGS:append = " -Wl,-O1" | ||
|
|
||
| inherit autotools systemd coverity pkgconfig | ||
|
|
||
| inherit coverity | ||
| inherit systemd | ||
| DEPENDS:append:client = " \ | ||
| openssl \ | ||
| libarchive \ | ||
| rdk-logger \ | ||
| commonutilities \ | ||
| rfc \ | ||
| telemetry \ | ||
| " |
There was a problem hiding this comment.
CFLAGS:append unconditionally enables RFC/T2/RDK logger related defines, but the build-time dependencies for those features are only added under DEPENDS:append:client. If this recipe is built under other overrides (e.g. :broadband), the build may fail or rely on undeclared/transitive deps. Either make the feature flags conditional (match the override) or move the required deps to the base DEPENDS/relevant override.
| do_install() { | ||
| install -d ${D}${base_libdir}/rdk | ||
| install -d ${D}${sysconfdir} ${D}${sysconfdir}/rfcdefaults | ||
| install -m 0755 ${S}/uploadDumps.sh ${D}${base_libdir}/rdk | ||
| install -m 0755 ${WORKDIR}/git/uploadDumps.sh ${D}${base_libdir}/rdk | ||
| install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk | ||
| } | ||
|
|
||
| do_install:append:client() { | ||
| install -d ${D}${bindir} | ||
| install -m 0755 ${B}/src/crashupload ${D}${bindir}/crashupload | ||
| } | ||
|
|
||
| do_install:append:broadband() { | ||
| use_sysv="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'false', 'true', d)}" | ||
| $use_sysv || install -d ${D}${systemd_unitdir}/system | ||
| $use_sysv || install -m 0644 ${S}/coredump-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${S}/coredump-upload.path ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.path ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/ | ||
| install -d ${D}${sysconfdir} | ||
| install -m 0755 ${S}/uploadDumpsUtils.sh ${D}${base_libdir}/rdk | ||
| install -m 0755 ${WORKDIR}/git/uploadDumpsUtils.sh ${D}${base_libdir}/rdk |
There was a problem hiding this comment.
The install steps reference source files via ${WORKDIR}/git/... even though S is set to a subdirectory. This hard-codes the unpack layout and can break developer workflows that enable externalsrc (see conf/distro/include/rdk-external-src.inc) or any future changes to S. Prefer deriving the repo-root path from ${S} (or keep S at repo root and point autotools at the subdir) so installs don’t depend on ${WORKDIR}/git.
| @@ -0,0 +1,38 @@ | |||
| SUMMARY = "Process Moniter utility and runner service" | |||
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 53 out of 53 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
recipes-devtools/meminsight/files/meminsight-upload.service:26
- This service runs
upload_MemReports.sh, which contains a sleep/retry loop and can run for a long time, but it is declaredType=oneshotwithout changingTimeoutStartSec. That risks systemd killing it during the first sleep. ConsiderType=simple(and removeRemainAfterExit) or setTimeoutStartSec=0/a sufficiently large value.
| [Service] | ||
| Type=oneshot | ||
| RemainAfterExit=yes | ||
| ExecStart=/media/apps/processmonitor/usr/bin/ProcessMonitor --duration 180 --output /opt/processMonitorResults.js -m /media/apps/processmonitor/usr/lib/libexithandler.so.1 |
RDKEMW-18969: Update bluetooth components to latest for gaming change…
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 53 out of 53 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (2)
recipes-devtools/meminsight/files/meminsight-upload.service:26
- The upload sidecar is triggered by a .path unit, but this oneshot service is left active after the script exits because RemainAfterExit is still set. After the first upload, later creations of /tmp/.meminsight_upload will not start a new upload unless the service is manually stopped; remove RemainAfterExit or explicitly stop/reset the unit after completion.
recipes-common/sys_mon_tools/sys-resource_git.bb:1 - Deleting this recipe leaves packagegroup-rdk-ccsp-broadband.bb still conditionally depending on sys-resource when DISTRO_FEATURES contains mlt. That build configuration will fail dependency resolution; remove or replace the remaining sys-resource packagegroup entry as part of this deletion.
| PR = "r0" | ||
| PACKAGE_ARCH = "${MIDDLEWARE_ARCH}" | ||
| SRCREV = "c613c0bd537704af56f7fdbf4a68a52edda1a64c" | ||
| SRCREV = "4941e3899ab9217382788296594cd14350586268" |
|
|
||
| # To have a possibility to override SRC_URI later, we are introducing the following workaround: | ||
| SRCREV = "7f22cb07a1ed27cec888d0db143bc13e817f407c" | ||
| SRCREV = "a97a431ad0d149f4dc9521cf1d49c150d421cce9" |
| LIC_FILES_CHKSUM = "file://LICENSE;md5=175792518e4ac015ab6696d16c4f607e" | ||
|
|
||
| SRCREV = "b4171d7741714e1d003abf83c9b4763f7911dbea" | ||
| SRCREV = "9db3fba319b7854e128cdba25f1ee36a312b4a3b" |
| PR = "r0" | ||
|
|
||
| SRCREV = "5c94e13903e76ded4b0780ca5b3c0e358362b489" | ||
| SRCREV = "d681f6b5906651b8dfe61c998d6127ccd4a55e96" |
| SRC_URI = "${CMF_GITHUB_ROOT}/crashupload;${CMF_GITHUB_SRC_URI_SUFFIX};module=." | ||
| S = "${WORKDIR}/git" | ||
| SRC_URI = "${CMF_GITHUB_ROOT}/${BPN}.git;nobranch=1;protocol=${CMF_GIT_PROTOCOL}" | ||
| SRCREV = "8fcb791cf927c91f53353cc6e5ac15a37bee1905" |
| SRCREV_rdk-libunpriv = "2e6c30c88823b7ff9cebde4d7f4d978118510da0" | ||
| SRC_URI = "${CMF_GITHUB_ROOT}/rdk-libunpriv.git;${CMF_GITHUB_SRC_URI_SUFFIX};name=rdk-libunpriv" | ||
|
|
||
| SRCREV_FORMAT = "rdk-libunpriv" |
| S = "${WORKDIR}/git" | ||
| DEPENDS += "rdk-logger" | ||
| SRCREV = "5143ba5b92f5dc77b436837d51f2f612d5846b7b" | ||
| SRCREV = "69fab9ab4403b7cda68af1d6a095b2cf5749c84f" |
RDKEMW-19074 : Meminsight csv files fail to get uploaded at configure
RDKEMW-18230: Create vdevice manifest with middleware compontents
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 53 out of 53 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (2)
recipes-devtools/meminsight/files/conf/client.conf:25
ExecStartPrecalls/usr/bin/tr181without thegetsubcommand/flag, but other usages in this PR usetr181 get ...(e.g. start_meminsight.sh). Iftr181requires an explicit get operation, this will always fail and leaveARGSempty.
recipes-common/sys_mon_tools/sys-resource_git.bb:1- This recipe is being removed, but
sys-resourceis still referenced byrecipes-core/packagegroups/packagegroup-rdk-ccsp-broadband.bbwhenDISTRO_FEATURESincludesmlt(see thebb.utils.contains(..., "sys-resource", ...)dependency). Removing it will cause build failures unless the packagegroup (or an alternative provider) is updated in the same change.
| if [ "${ENABLE_SYSLOGNG}" = "true" ]; then | ||
| echo "SYSLOG_NG_ENABLED=true" >> ${D}${sysconfdir}/device-middleware.properties | ||
| fi |
| if [ "$UPLOAD_INTERVAL" -eq 0 ]; then | ||
| UPLOAD_INTERVAL=900 | ||
| log "No upload interval configured; defaulting to 900 seconds." | ||
| fi |
| load_configstore | ||
| last_hash="$current_hash" | ||
| # Recompute derived values that depend on OUTPUT_DIR / UPLOAD_INTERVAL. | ||
| [ "$UPLOAD_INTERVAL" -eq 0 ] && UPLOAD_INTERVAL=900 |
| CFLAGS:append = " \ | ||
| -I=${libdir}/glib-2.0/include \ | ||
| -I=${includedir}/glib-2.0 \ | ||
| -DRFC_API_ENABLED \ | ||
| -DT2_EVENT_ENABLED \ | ||
| -DRDK_LOGGER \ | ||
| -DUSE_EXTENDED_LOGGER_INIT \ | ||
| -DRBUS_API_ENABLED \ | ||
| " |
| log_info() { | ||
| echo "[start_meminsight] [INFO] $*" >> $RDM_LOG_FILE | ||
| } | ||
|
|
||
| log_error() { | ||
| echo "[start_meminsight] [ERROR] $*" >> $RDM_LOG_FILE | ||
| } |
| Type=simple | ||
| RemainAfterExit=yes | ||
| EnvironmentFile=-/tmp/meminsight.env |
RDKEMW-19370 : Integrate RFC 1.2.6 Release for RDKE Devices
No description provided.