Rebase by KTirumalaSrihari · Pull Request #680 · rdkcentral/meta-rdk

KTirumalaSrihari · 2026-03-23T15:18:36Z

No description provided.

Reason for change: Added forked version git hash id for testing Test Procedure: please refer the ticket comments Risks: Medium

rebase develop

Rebased develop

Change-Id: Ie81f3292f451e48577ee30acecc96d7e623c9ed8 Signed-off-by: Gurdal Oruklu <gurdal_oruklu@comcast.com>

RDKEMW-14726 : Implement Chrony runtime selection for Time Sync (#632)

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>

…-swap-limit RDKEMW-15176: added dobby patch for increased swap limit for containers

RDKEMW-15233: Integrate 0.0.1 release for reboot-manager

* Update rfc_git.bb * RDKEMW-15263: command injection via /lib/rdk/getRFC.sh --------- Co-authored-by: Saranya2421 <saranya.suvi@gmail.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR updates several Yocto/OE recipes to new source revisions/versions as part of a rebase, and adjusts the chrony first-sync notification script behavior/logging.

Changes:

Bump systimemgr recipe PV and SRCREV.
Adjust rfc recipe PV/PR metadata.
Update reboot-manager recipe SRCREV (and PV).
Change chrony-sync-notify.sh logging format and NTP-flag creation behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
recipes-support/reboot-manager/reboot-manager.bb	Updates reboot-manager PV and SRCREV to a new revision.
recipes-support/chrony/files/chrony-sync-notify.sh	Changes logging format and alters creation/handling of the NTP flag file.
recipes-common/systimemgr/systimemgr_git.bb	Bumps PV and advances SRCREV for systemtimemgr.
recipes-common/rfc/rfc_git.bb	Updates PV/PR metadata for RFC recipe.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T15:21:23Z

+if [  -d "$NTP_DIR" ]; then
+   if touch "$NTP_FILE" && chmod 644 "$NTP_FILE"; then
+      log "Created $NTP_FILE"
+   else
+      log "Failed to create or set permissions on $NTP_FILE"
+      exit 1
+   fi
+else
+   log "Directory $NTP_DIR does not exist; cannot create $NTP_FILE"


The script used to create $NTP_DIR when missing, but now exits with an error if /tmp/systimemgr does not exist. Since this directory is only referenced in this script (no other creators found), this change can cause chrony-sync-notify to fail on first boot and never create the NTP flag. Consider restoring mkdir -p "$NTP_DIR" (and logging) when the directory is absent, instead of exiting.

Suggested change

if [ -d "$NTP_DIR" ]; then

if touch "$NTP_FILE" && chmod 644 "$NTP_FILE"; then

log "Created $NTP_FILE"

else

log "Failed to create or set permissions on $NTP_FILE"

exit 1

fi

else

log "Directory $NTP_DIR does not exist; cannot create $NTP_FILE"

if [ ! -d "$NTP_DIR" ]; then

log "Creating $NTP_DIR"

if ! mkdir -p "$NTP_DIR"; then

log "Failed to create $NTP_DIR"

exit 1

fi

fi

if touch "$NTP_FILE" && chmod 644 "$NTP_FILE"; then

log "Created $NTP_FILE"

else

log "Failed to create or set permissions on $NTP_FILE"

Copilot · 2026-03-23T15:21:24Z

+if [  -d "$NTP_DIR" ]; then
+   if touch "$NTP_FILE" && chmod 644 "$NTP_FILE"; then
+      log "Created $NTP_FILE"
+   else
+      log "Failed to create or set permissions on $NTP_FILE"
+      exit 1


This block unconditionally runs touch "$NTP_FILE" and logs "Created" even if the file already exists, which changes the previous behavior (only create/log when missing) and may unnecessarily update mtime for any watcher. Consider keeping the old if [ ! -f "$NTP_FILE" ] guard or adjusting the log message to reflect whether the file was newly created.

Suggested change

if [ -d "$NTP_DIR" ]; then

if touch "$NTP_FILE" && chmod 644 "$NTP_FILE"; then

log "Created $NTP_FILE"

else

log "Failed to create or set permissions on $NTP_FILE"

exit 1

if [ -d "$NTP_DIR" ]; then

if [ ! -f "$NTP_FILE" ]; then

if touch "$NTP_FILE" && chmod 644 "$NTP_FILE"; then

log "Created $NTP_FILE"

else

log "Failed to create or set permissions on $NTP_FILE"

exit 1

fi

else

if chmod 644 "$NTP_FILE"; then

log "Updated permissions on existing $NTP_FILE"

else

log "Failed to set permissions on existing $NTP_FILE"

exit 1

fi

Copilot · 2026-03-23T15:21:24Z

@@ -11,12 +11,12 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"

 FILESEXTRAPATHS:prepend := "${THISDIR}:"



PV is being lowered from 1.0.0 to 0.0.1. In Yocto/OE version comparisons, decreasing PV can prevent upgrades or cause downgrades in feeds/images unless PE is bumped. If this is intentional (e.g., previous PV was incorrect), consider adding/adjusting PE or keeping PV monotonic to avoid upgrade-path issues.

Suggested change

PE = "1"

Copilot · 2026-03-23T15:21:24Z

-PR = "r1"
+PV = "1.2.3"
+PR = "r0"



PV/PR are updated (1.2.1-r1 -> 1.2.3-r0) but SRCREV is unchanged. If this is meant to be an upstream version bump, SRCREV should typically move to the corresponding revision/tag; otherwise consumers may assume new code when the source is identical. If the intent is only to correct the displayed version, please add a brief comment clarifying why the commit stays the same.

Suggested change

# Note: PV/PR updated for packaging/version display only; upstream source remains at this SRCREV.

Rebased develop

…ot-manager-dev (#662)

…585) Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-24T11:42:29Z

 echo "Synchronized" > /tmp/ntp_status

+if [  -d "$NTP_DIR" ]; then
+   if touch "$NTP_FILE" && chmod 644 "$NTP_FILE"; then


/tmp/ntp_status is written before the new $NTP_DIR/$NTP_FILE creation logic that can now fail and exit 1. That can leave ntp_status saying "Synchronized" even though the script reports failure. Consider only writing ntp_status after the $NTP_FILE step succeeds (or cleaning it up on failure).

Suggested change

echo "Synchronized" > /tmp/ntp_status

if [ -d "$NTP_DIR" ]; then

if touch "$NTP_FILE" && chmod 644 "$NTP_FILE"; then

if [ -d "$NTP_DIR" ]; then

if touch "$NTP_FILE" && chmod 644 "$NTP_FILE"; then

echo "Synchronized" > /tmp/ntp_status

Copilot · 2026-03-24T11:42:30Z

+PV = "1.2.3"
+PR = "r0"

 SRCREV = "904a9167f2cbe87dc34d342e32f5ca16b177432c"
 SRC_URI = "${CMF_GITHUB_ROOT}/rfc;${CMF_GITHUB_SRC_URI_SUFFIX};name=rfc"


PV was bumped to 1.2.3, but SRCREV is unchanged. As written, this will build the same source revision under a new version, which can confuse debugging and package feeds. Either update SRCREV to the commit that corresponds to 1.2.3, or keep PV aligned to the pinned revision (common pattern is PV = "<release>+git${SRCPV}").

…s 1.0.10

This reverts commit cfad84d.

RDKEMW-15263: command injection via /lib/rdk/getRFC.sh

Rebased develop

Copilot

Pull request overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated 3 comments.

+SRC_URI = "git://github.com/gomathishankar37/ProcessMonitor.git;protocol=https;branch=exit-handler"
+
+SRC_URI:append = " file://process-monitor.path \
+                   file://process-monitor.service \
+                   "
+
+inherit cmake systemd
+
+EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release"
+
+# SRCREV = "63c19611d52cec3331bc9ea1bc82175f5d8a9c96"
+SRCREV = "${AUTOREV}"


+parse_settings() {
+    local raw="$1"
+    s_type=$(echo "$raw"      | cut -d',' -f1)
+    s_maxsources=$(echo "$raw" | cut -d',' -f2)
+    s_iburst=$(echo "$raw"    | cut -d',' -f3)
+    s_minpoll=$(echo "$raw"   | cut -d',' -f4)
+    s_maxpoll=$(echo "$raw"   | cut -d',' -f5)
+
+    # Normalise type: only "pool" is special, everything else is "server"
+    [ "$s_type" = "pool" ] || s_type="server"
+
+    # Validate poll values; fall back to defaults if non-numeric or inverted
+    [[ "$s_minpoll" =~ ^[0-9]+$ ]] || s_minpoll="$DEFAULT_MINPOLL"
+    [[ "$s_maxpoll" =~ ^[0-9]+$ ]] || s_maxpoll="$DEFAULT_MAXPOLL"
+    if [ "$s_minpoll" -gt "$s_maxpoll" ]; then
+        ntpLog "WARNING: minpoll ($s_minpoll) > maxpoll ($s_maxpoll) in settings '$raw', using defaults"
+        s_minpoll="$DEFAULT_MINPOLL"
+        s_maxpoll="$DEFAULT_MAXPOLL"
+    fi
+
+    # Normalise iburst: only literal "true" enables it
+    [ "$s_iburst" = "true" ] || s_iburst="false"
+}


+log_info() {
+    echo "[start_meminsight] [INFO] $*" >> $RDM_LOG_FILE
+}
+
+log_error() {
+    echo "[start_meminsight] [ERROR] $*" >> $RDM_LOG_FILE
+}
+


Copilot

Pull request overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 3 comments.

+[Unit]
+Description=Process Moniter
+OnFailure=path-fail-notifier@%n.service


+Type=simple
+RemainAfterExit=yes
+EnvironmentFile=-/tmp/meminsight.env
+ExecStart=/bin/sh -c 'PATH="/run/meminsight/usr/bin:/media/apps/meminsight:/media/apps/meminsight/usr/bin:$PATH"; meminsight $ARGS'
+ExecStop=-/bin/rm /tmp/.meminsight_upload /tmp/.meminsight_inprogress
+ExecStopPost=-/bin/rm /tmp/meminsight.env /tmp/.enable_meminsight /nvram/.enable_meminsight
+Restart=on-failure
+RestartSec=30


+log_info() {
+    echo "[start_meminsight] [INFO] $*" >> $RDM_LOG_FILE
+}
+
+log_error() {
+    echo "[start_meminsight] [ERROR] $*" >> $RDM_LOG_FILE
+}


…s 1.0.11

Copilot

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 3 comments.

+log_info() {
+    echo "[start_meminsight] [INFO] $*" >> $RDM_LOG_FILE
+}
+
+log_error() {
+    echo "[start_meminsight] [ERROR] $*" >> $RDM_LOG_FILE
+}


+
+[Service]
+Type=simple
+RemainAfterExit=yes


+# Remove the upload trigger file so the systemd path unit does not
+# immediately re-trigger the service after a graceful exit.
+cleanup_upload_trigger() {
+    rm -f "$UPLOAD_TRIGGER_PATH" >/dev/null 2>&1 || true
+}
+
+# Acquire an exclusive instance lock via atomic mkdir.
+# Registers cleanup_lock via trap so the lock is always released on exit.
+# Exits with code 0 (not an error) if another instance already holds the lock.
+acquire_lock() {
+    if ! mkdir "$LOCK_DIR" >/dev/null 2>&1; then
+        log "Another upload instance is already running; exiting."
+        exit 0
+    fi
+    trap cleanup_lock EXIT INT TERM
+}


…config mode (#889)

RDKEMW-18969: Update bluetooth components to latest for gaming change…

Copilot

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

recipes-devtools/meminsight/files/meminsight-upload.service:27

This oneshot unit sets RemainAfterExit=yes. Because it is started by a .path trigger, keeping the service in "active" state after the script exits can prevent subsequent path events from starting it again (e.g., next meminsight run). Consider removing RemainAfterExit (default no) so the service returns to inactive after completion.

+SUMMARY = "Process Moniter utility and runner service"
+DESCRIPTION = "Linux process monitor - track and record the execution times of all processes"


+[Service]
+Type=simple
+RemainAfterExit=yes
+EnvironmentFile=-/tmp/meminsight.env
+ExecStart=/bin/sh -c 'PATH="/run/meminsight/usr/bin:/media/apps/meminsight:/media/apps/meminsight/usr/bin:$PATH"; meminsight $ARGS'
+ExecStop=-/bin/rm /tmp/.meminsight_upload /tmp/.meminsight_inprogress
+ExecStopPost=-/bin/rm /tmp/meminsight.env /tmp/.enable_meminsight /nvram/.enable_meminsight
+Restart=on-failure


…d intervals

RDKEMW-19074 : Meminsight csv files fail to get uploaded at configure

RDKEMW-18230: Create vdevice manifest with middleware compontents

Copilot

Pull request overview

Copilot reviewed 49 out of 49 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

recipes-devtools/meminsight/files/meminsight-upload.service:26

RemainAfterExit=yes keeps this oneshot service in an ‘active’ state after it exits, which can prevent subsequent path-triggered starts (systemd won’t start an already-active unit). For a PathExists-triggered oneshot, this should typically be removed.

+do_install:append() {
+        install -d ${D}${bindir}
+        install -d ${D}${systemd_unitdir}/system
+        install -m 0644 ${S}/services/update-reboot-info.path ${D}${systemd_unitdir}/system
+        install -m 0644 ${S}/services/update-reboot-info.service ${D}${systemd_unitdir}/system
+
+        if [ "${ENABLE_SYSLOGNG}" = "true" ]; then
+           echo "SYSLOG_NG_ENABLED=true" >> ${D}${sysconfdir}/device-middleware.properties
+        fi
+


@@ -0,0 +1,38 @@
+SUMMARY = "Process Moniter utility and runner service"


+[Unit]
+Description=Process Moniter
+OnFailure=path-fail-notifier@%n.service


+do_install:append () {
+    install -d ${D}${systemd_unitdir}/system
+    rm -rf ${S}/process-monitor.service
+    install -m 0644 ${WORKDIR}/process-monitor.service ${D}${systemd_unitdir}/system
+    install -m 0644 ${WORKDIR}/process-monitor.path ${D}${systemd_unitdir}/system
+}


+[Service]
+Type=oneshot
+RemainAfterExit=yes
+ExecStart=/media/apps/processmonitor/usr/bin/ProcessMonitor --duration 180 --output /opt/processMonitorResults.js -m /media/apps/processmonitor/usr/lib/libexithandler.so.1


+[Service]
+Type=oneshot
+RemainAfterExit=yes
+ExecStart=/media/apps/processmonitor/usr/bin/ProcessMonitor --duration 180 --output /opt/processMonitorResults.js -m /media/apps/processmonitor/usr/lib/libexithandler.so.1


RDKEMW-19370 : Integrate RFC 1.2.6 Release for RDKE Devices

tabbas651 and others added 14 commits March 2, 2026 22:26

RDKEMW-14121 : Added Mediatek Platform support in Memcapture Code Base

146a690

Reason for change: Added forked version git hash id for testing Test Procedure: please refer the ticket comments Risks: Medium

Resolved the Mediatek Build Error

7e69238

Merge pull request #631 from rdkcentral/develop

a0ac976

rebase develop

Merge pull request #642 from rdkcentral/develop

e9c0ee7

Rebased develop

RDKEMW-15176: added dobby patch for increased swap limit for containers

9db063f

Change-Id: Ie81f3292f451e48577ee30acecc96d7e623c9ed8 Signed-off-by: Gurdal Oruklu <gurdal_oruklu@comcast.com>

Merge pull request #649 from rdkcentral/develop

2815d58

RDKEMW-14726 : Implement Chrony runtime selection for Time Sync (#632)

RDKEMW-15233: Integrate 0.0.1 release for reboot-manager

ee67c6c

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>

Merge pull request #660 from rdkcentral/feature/RDKEMW-15231-increase…

67a7b04

…-swap-limit RDKEMW-15176: added dobby patch for increased swap limit for containers

Merge pull request #659 from rdkcentral/topic/RDKEMW-15233

a83918a

RDKEMW-15233: Integrate 0.0.1 release for reboot-manager

RDKEMW-15263: command injection via /lib/rdk/getRFC.sh (#672)

cfad84d

* Update rfc_git.bb * RDKEMW-15263: command injection via /lib/rdk/getRFC.sh --------- Co-authored-by: Saranya2421 <saranya.suvi@gmail.com>

Update systimemgr_git.bb

a91a9b5

Update chrony-sync-notify.sh

154ecae

Apply suggestion from @Copilot

af210ef

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

RDKEMW-15664 : handle deepsleep in chrony (#671)

74b7827

KTirumalaSrihari requested a review from a team as a code owner March 23, 2026 15:18

Copilot AI review requested due to automatic review settings March 23, 2026 15:18

KTirumalaSrihari requested a review from a team as a code owner March 23, 2026 15:18

Copilot started reviewing on behalf of KTirumalaSrihari March 23, 2026 15:19 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

tabbas651 and others added 3 commits March 23, 2026 14:37

Merge pull request #682 from rdkcentral/develop

1639f55

Rebased develop

RDKEMW-15467 : do_populate_sdk task fails for MW test image with rebo…

802d3fb

…ot-manager-dev (#662)

RDK-60307 [RRD] RDK Coverity Defect Resolution for Device Management (#…

a1b4e6c

…585) Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>

Copilot AI review requested due to automatic review settings March 24, 2026 11:39

Copilot started reviewing on behalf of tdeva14 March 24, 2026 11:39 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

DamianoBaroneSky and others added 5 commits March 24, 2026 14:35

RDKEMW-15944: Update bluetooth components to latest for gaming change…

7693d32

…s 1.0.10

Revert "RDKEMW-15263: command injection via /lib/rdk/getRFC.sh (#672)"

f6a5e8a

This reverts commit cfad84d.

Merge pull request #689 from rdkcentral/revert-672-feature/RDKEMW-15263

c04edd7

RDKEMW-15263: command injection via /lib/rdk/getRFC.sh

Merge pull request #691 from rdkcentral/develop

ceca4aa

Rebased develop

Update the GeyGPUmemory changes

fddf930

Copilot AI review requested due to automatic review settings May 18, 2026 12:27

Copilot started reviewing on behalf of tdeva14 May 18, 2026 12:28 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

rosemarybennyy and others added 2 commits May 20, 2026 13:48

RDKEMW-18087 : Build Meminsight in RDKE with latest 1.1.0 changes (#839)

54fd60d

RDKEMW-18410: Integrate Telemetry release 1.9.4 (#863)

c9f543c

Copilot AI review requested due to automatic review settings May 21, 2026 04:44

Copilot AI reviewed May 21, 2026

View reviewed changes

DamianoBaroneSky and others added 3 commits May 21, 2026 16:15

RDKEMW-18969: Update bluetooth components to latest for gaming change…

cfc2f2d

…s 1.0.11

Update dcmd.bb (#869)

60f15c8

RDKEMW-15246 : Chrony Enhancements (#878)

9ce634f

Copilot AI review requested due to automatic review settings May 26, 2026 09:44

Copilot started reviewing on behalf of tdeva14 May 26, 2026 09:44 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

gomathishankar37 and others added 3 commits May 27, 2026 10:56

RDKB-64769, RDKEMW-18610: Update MAC address logic and CPU_TIME for …

c1587e6

…config mode (#889)

Merge branch 'develop' into feature/RDKEMW-18969

1dba172

Merge pull request #883 from rdkcentral/feature/RDKEMW-18969

3739f4e

RDKEMW-18969: Update bluetooth components to latest for gaming change…

Copilot AI review requested due to automatic review settings May 28, 2026 00:24

Copilot started reviewing on behalf of plaksh002c-public May 28, 2026 00:24 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

rosemarybennyy and others added 6 commits May 28, 2026 09:12

RDKEMW-19074 : Meminsight csv files fail to get uploaded at configure…

7b31d41

…d intervals

removed logfile redirection

2273ab9

Merge pull request #891 from rdkcentral/topic/RDKEMW-19074

e3c4dc5

RDKEMW-19074 : Meminsight csv files fail to get uploaded at configure

RDKEMW-18230: Create vdevice manifest with middleware compontents

9284c3c

RDKEMW-19370 : Integrate RFC 1.2.6 Release for RDKE Devices

46d43d7

Merge pull request #900 from rdkcentral/topic/RDKEMW-18230_aidl

0133066

RDKEMW-18230: Create vdevice manifest with middleware compontents

Copilot AI review requested due to automatic review settings June 2, 2026 14:41

Copilot started reviewing on behalf of plaksh002c-public June 2, 2026 14:41 View session

Copilot AI reviewed Jun 2, 2026

View reviewed changes

madhubabutt and others added 2 commits June 3, 2026 11:04

Merge branch 'develop' into feature/RDKEMW-19370

76b016b

Merge pull request #903 from rdkcentral/feature/RDKEMW-19370

4a1db3a

RDKEMW-19370 : Integrate RFC 1.2.6 Release for RDKE Devices

		@@ -11,12 +11,12 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"

		FILESEXTRAPATHS:prepend := "${THISDIR}:"



	# Note: PV/PR updated for packaging/version display only; upstream source remains at this SRCREV.

		SUMMARY = "Process Moniter utility and runner service"
		DESCRIPTION = "Linux process monitor - track and record the execution times of all processes"

		@@ -0,0 +1,38 @@
		SUMMARY = "Process Moniter utility and runner service"

Conversation

KTirumalaSrihari commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants