rebase#761
Open
sindhu-krishnan wants to merge 90 commits into
Open
Conversation
Change-Id: Ie81f3292f451e48577ee30acecc96d7e623c9ed8 Signed-off-by: Gurdal Oruklu <gurdal_oruklu@comcast.com>
…-swap-limit RDKEMW-15176: added dobby patch for increased swap limit for containers
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update systimemgr_git.bb * Update chrony-sync-notify.sh * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RDKEMW-15233: Integrate 0.0.1 release for reboot-manager
RDKEMW-15233: Integrate Telemetry Release 1.8.5
…lm_before_bluez-r8530 RDKEMW-15815: [8.5.3.0] stop ctrlm-main service before bluez for graceful reboot
…boot - Merge To develop Reason for change: Updated the git hash id for RBUS handler starvation and race condition on privacyModeVal Test Procedure: please referr the ticket Risks: Medium
RDKEMW-15567: Backmerge release branch to develop for MW 8.5.3.0
Rebased develop
RDKEMW-16758: [RDKEMW][Alpaca DE]Box boot up time is extended post reboot - Merge To develop
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
recipes-devtools/meminsight/meminsight_git.bb:94
- FILES adds the upload script via a hardcoded "/lib/rdk" path. Prefer using ${base_libdir}/rdk here as well (matching the install location and making the recipe work correctly if base_libdir isn’t /lib).
FILES:${PN} += "${systemd_unitdir}/system/meminsight-upload.service"
FILES:${PN} += "${systemd_unitdir}/system/meminsight-upload.path"
FILES:${PN} += "/lib/rdk/upload_MemReports.sh"
Comment on lines
+59
to
+61
| if [ "${ENABLE_SYSLOGNG}" = "true" ]; then | ||
| echo "SYSLOG_NG_ENABLED=true" >> ${D}${sysconfdir}/device-middleware.properties | ||
| fi |
Comment on lines
+24
to
+25
| Type=oneshot | ||
| RemainAfterExit=yes |
| [Service] | ||
| Type=oneshot | ||
| Type=simple | ||
| RemainAfterExit=yes |
Comment on lines
+36
to
+40
| PACKAGECONFIG[cjson] = "--enable-cjson,--disable-cjson" | ||
|
|
||
| EXTRA_OECONF += "${@bb.utils.contains('PACKAGECONFIG', 'cjson', '--enable-cjson', '--disable-cjson', d)}" | ||
| RDEPENDS:${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'cjson', 'cjson', '', d)}" | ||
|
|
Comment on lines
+55
to
+56
| install -d ${D}/lib/rdk | ||
| install -m 0755 ${WORKDIR}/upload_MemReports.sh ${D}/lib/rdk/upload_MemReports.sh |
Comment on lines
+100
to
+108
| # Acquire an exclusive instance lock via atomic mkdir. | ||
| # Registers cleanup_lock via trap so the lock is always released on exit. | ||
| # Exits with code 0 (not an error) if another instance already holds the lock. | ||
| acquire_lock() { | ||
| if ! mkdir "$LOCK_DIR" >/dev/null 2>&1; then | ||
| log "Another upload instance is already running; exiting." | ||
| exit 0 | ||
| fi | ||
| trap cleanup_lock EXIT INT TERM |
Comment on lines
+247
to
+272
| if [ "$BUILD_TYPE" != "prod" ] && [ -f /opt/dcm.properties ]; then | ||
| log "Configurable service end-points will not be used for $BUILD_TYPE builds due to overridden /opt/dcm.properties." | ||
| else | ||
| if command -v tr181 >/dev/null 2>&1; then | ||
| LOG_SERVER="$(tr181 -g Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.LogUpload.LogServerUrl 2>/dev/null)" | ||
|
|
||
| if [ -f "$OUTFILE" ]; then | ||
| HTTP_UPLOAD_LINK="$(grep 'LogUploadSettings:UploadRepository:URL' "$OUTFILE" | cut -d '=' -f2 | sed 's/^"//' | sed 's/"$//')" | ||
| UPLOAD_PROTOCOL="$(grep 'LogUploadSettings:UploadRepository:uploadProtocol' "$OUTFILE" | cut -d '=' -f2 | sed 's/^"//' | sed 's/"$//')" | ||
| fi | ||
|
|
||
| if [ -z "$HTTP_UPLOAD_LINK" ]; then | ||
| UPLOAD_HTTPLINK_URL="$(tr181 -g Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.LogUpload.SsrUrl 2>/dev/null)" | ||
| if [ -n "$UPLOAD_HTTPLINK_URL" ]; then | ||
| HTTP_UPLOAD_LINK="${UPLOAD_HTTPLINK_URL}/cgi-bin/S3.cgi" | ||
| fi | ||
| fi | ||
| fi | ||
| fi | ||
|
|
||
| [ -n "$UPLOAD_PROTOCOL" ] || UPLOAD_PROTOCOL="HTTP" | ||
|
|
||
| if [ -z "$LOG_SERVER" ] || [ -z "$HTTP_UPLOAD_LINK" ]; then | ||
| if [ "$BUILD_TYPE" != "prod" ] && [ -f /opt/dcm.properties ]; then | ||
| # shellcheck disable=SC1091 | ||
| . /opt/dcm.properties |
RDKEMW-18969: Update bluetooth components to latest for gaming change…
RDKEMW-19074 : Meminsight csv files fail to get uploaded at configure
RDKEMW-18230: Create vdevice manifest with middleware compontents
Comment on lines
+59
to
+61
| if [ "${ENABLE_SYSLOGNG}" = "true" ]; then | ||
| echo "SYSLOG_NG_ENABLED=true" >> ${D}${sysconfdir}/device-middleware.properties | ||
| fi |
Comment on lines
+35
to
+39
| PACKAGECONFIG ??= "cjson" | ||
| PACKAGECONFIG[cjson] = "--enable-cjson,--disable-cjson" | ||
|
|
||
| EXTRA_OECONF += "${@bb.utils.contains('PACKAGECONFIG', 'cjson', '--enable-cjson', '--disable-cjson', d)}" | ||
| RDEPENDS:${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'cjson', 'cjson', '', d)}" |
Comment on lines
+55
to
+56
| install -d ${D}/lib/rdk | ||
| install -m 0755 ${WORKDIR}/upload_MemReports.sh ${D}/lib/rdk/upload_MemReports.sh |
|
|
||
| FILES:${PN} += "${systemd_unitdir}/system/meminsight-upload.service" | ||
| FILES:${PN} += "${systemd_unitdir}/system/meminsight-upload.path" | ||
| FILES:${PN} += "/lib/rdk/upload_MemReports.sh" |
Comment on lines
+23
to
+26
| [Service] | ||
| Type=oneshot | ||
| RemainAfterExit=yes | ||
| ExecStart=/lib/rdk/upload_MemReports.sh |
Comment on lines
+24
to
26
| Type=simple | ||
| RemainAfterExit=yes | ||
| EnvironmentFile=-/tmp/meminsight.env |
RDKEMW-19370 : Integrate RFC 1.2.6 Release for RDKE Devices
RDKEMW-18858: Back merge Release branch to develop for 8.6.2.0 Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.