RDKEMW-19246 : Enable firmware-independent OTA Updates for MemInsight#910
Open
rosemarybennyy wants to merge 2 commits into
Open
RDKEMW-19246 : Enable firmware-independent OTA Updates for MemInsight#910rosemarybennyy wants to merge 2 commits into
rosemarybennyy wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables firmware-independent OTA update support for MemInsight by updating RDM agent and adding MemInsight packaging metadata plus runtime path handling for app installs under /media/apps.
Changes:
- Bump
rdmagentrecipe version and source revision to pick up updated OTA/app-management behavior. - Add a MemInsight
package.jsonmetadata file to the layer and reference it from the MemInsight recipe. - Update
start_meminsight.shto re-point/media/apps/meminsightto a model-specific app directory.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| recipes-support/rdmagent/rdmagent.bb | Bumps PV and SRCREV to a newer rdm-agent revision. |
| recipes-devtools/meminsight/meminsight_git.bb | Adds package.json to SRC_URI. |
| recipes-devtools/meminsight/files/start_meminsight.sh | Adjusts runtime app path via /media/apps/meminsight symlink and reorders variable setup. |
| recipes-devtools/meminsight/files/package.json | Introduces MemInsight OTA/package metadata including install script reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+44
to
+46
| APP_HOME_DIR=/media/apps/${MODEL_NUM}-meminsight | ||
| rm -rf /media/apps/meminsight | ||
| ln -snf "$APP_HOME_DIR" /media/apps/meminsight |
Comment on lines
+48
to
+50
| SRC_BIN="/media/apps/meminsight/usr/bin/meminsight" | ||
| DST_BIN="/run/meminsight/usr/bin/meminsight" | ||
| RFC_PARAM="Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.meminsight.Trigger" |
Comment on lines
+1
to
+8
| { | ||
| "name": "meminsight", | ||
| "description": "Performance Monitoring tool - meminsight", | ||
| "version": "1.1", | ||
| "contents": ["meminsight-pkg.tar"], | ||
| "size": "72K", | ||
| "installScript": "/etc/rdm/post-services/start_meminsight.sh" | ||
| } |
Comment on lines
18
to
22
| file://meminsight-upload.service \ | ||
| file://meminsight-upload.path \ | ||
| file://upload_MemReports.sh \ | ||
| file://package.json \ | ||
| " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Enable firmware-independent OTA Updates for MemInsight
Test Procedure: Tested and verified
Risks: Low
Priority: P1
Signed-off-by: RoseMary_Benny@comcast.com