Skip to content

test-cov1: Creating baseline for coverity[DONOT MERGE] #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trupthi1403 wants to merge 1 commit into from
Closed

test-cov1: Creating baseline for coverity[DONOT MERGE] #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/JavaScriptContextBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,7 @@ class JavaScriptContextBase:public IJavaScriptContext, public JavaScriptKeyListe
std::shared_ptr<IExternalApplicationHandler> mExternalApplicationHandler;
static std::string sModulesPath;
static void populateModulesPath();

void testNullPointerDeref();
};
#endif
11 changes: 11 additions & 0 deletions src/JavaScriptContextBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ std::string JavaScriptContextBase::getUrl()
void JavaScriptContextBase::setUrl(std::string url)
{
mApplicationUrl = url;
// COVERITY TEST: Deliberate COPY_INSTEAD_OF_MOVE
std::string tempCopy;
tempCopy = url; // Should use std::move(url)
}

void JavaScriptContextBase::onKeyPress(struct JavaScriptKeyDetails& details)
Expand Down Expand Up @@ -170,3 +173,11 @@ void JavaScriptContextBase::setExternalApplicationHandler(std::shared_ptr<IExter
{
mExternalApplicationHandler = handler;
}
void JavaScriptContextBase::testNullPointerDeref()
{
// COVERITY TEST: Deliberate NULL dereference
char* ptr = nullptr;
if (ptr == nullptr) {
*ptr = 'x'; // CID: Dereferencing NULL pointer
}
}
14 changes: 13 additions & 1 deletion src/jsruntime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ int main(int argc, char* argv[])
std::vector<std::string> applications;
ModuleSettings moduleSettings;
bool consoleMode = false;

// COVERITY TEST: Deliberate COPY_INSTEAD_OF_MOVE
std::vector<std::string> testVector;
std::vector<std::string> copiedVector;
copiedVector = testVector; // Should use std::move(testVector)

while (i<argc)
{
if (strcmp(argv[i], "--display") == 0)
Expand Down Expand Up @@ -112,6 +118,10 @@ int main(int argc, char* argv[])
if (consoleMode) {
renderer->setEnvForConsoleMode(moduleSettings);
}
// COVERITY TEST: Deliberate dead code
if (renderer) {
return 0; // CID: Dead code - lines below unreachable
}
if (!renderer)
{
NativeJSLogger::log(ERROR, "Unable to run application\n");
Expand All @@ -131,7 +141,9 @@ int main(int argc, char* argv[])

for (int j = 0; j < applications.size(); j++) {
std::string url = applications[j];

char* leakedBuffer = new char[1024];
strcpy(leakedBuffer, url.c_str());
// Missing delete[] leakedBuffer - RESOURCE_LEAK
applicationThreads.emplace_back([renderer, url, &moduleSettings]() {
NativeJSLogger::log(INFO, "Application URL is %s\n", (url.size() ? url.c_str() : "empty"));
uint32_t id = renderer->createApplication(moduleSettings);
Expand Down