RDKEMW-14984: VIPA playback is stopping with 2.0.3 nativescript tag#128
Merged
Conversation
Reason for change: changed the jsbinding lib for dynamic loading Test Procedure: build should be successful Risk: low Priority: P2
Contributor
There was a problem hiding this comment.
Pull request overview
Updates JS DOM bindings and runtime initialization to support dynamic loading and improve JSDOM/MiniJSDOM behavior, aiming to prevent VIPA playback from stopping with the 2.0.3 NativeScript tag.
Changes:
- Updated JSDOM/minified DOM shims (timers, Blob polyfill, document helpers) to better match expected JS runtime behavior.
- Switched dynamically loaded JS bindings symbols to new (non-mangled) names.
- Added Firebolt endpoint injection and expanded window location initialization to run for both MiniJSDOM and JSDOM.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/jsc/modules/minified_linkedjsdom.js | Enhances DOM/timer/polyfill behavior and adds runtime globals expected by JS apps. |
| src/jsc/modules/linkedjsdomwrapper.js | Exposes HTMLElement from window into the global scope for wrapper compatibility. |
| src/jsc/JavaScriptContext.cpp | Updates dlsym symbols and injects Firebolt endpoint + DOM setup at startup when env var is set. |
| src/NativeJSRenderer.cpp | Applies window.location setup for JSDOM as well as MiniJSDOM. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vjain008
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: changed the jsbinding lib for dynamic loading
Test Procedure: build should be successful
Risk: low
Priority: P2