Skip to content

RDKEMW-14984: VIPA playback is stopping with 2.0.3 nativescript tag#128

Merged
vjain008 merged 2 commits into
developfrom
topic/RDKEMW-14984
Mar 18, 2026
Merged

RDKEMW-14984: VIPA playback is stopping with 2.0.3 nativescript tag#128
vjain008 merged 2 commits into
developfrom
topic/RDKEMW-14984

Conversation

@gurpreet319
Copy link
Copy Markdown
Contributor

Reason for change: changed the jsbinding lib for dynamic loading
Test Procedure: build should be successful
Risk: low
Priority: P2

Reason for change: changed the jsbinding lib for dynamic loading
Test Procedure: build should be successful
Risk: low
Priority: P2
@gurpreet319 gurpreet319 requested a review from a team as a code owner March 18, 2026 03:05
Copilot AI review requested due to automatic review settings March 18, 2026 03:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates JS DOM bindings and runtime initialization to support dynamic loading and improve JSDOM/MiniJSDOM behavior, aiming to prevent VIPA playback from stopping with the 2.0.3 NativeScript tag.

Changes:

  • Updated JSDOM/minified DOM shims (timers, Blob polyfill, document helpers) to better match expected JS runtime behavior.
  • Switched dynamically loaded JS bindings symbols to new (non-mangled) names.
  • Added Firebolt endpoint injection and expanded window location initialization to run for both MiniJSDOM and JSDOM.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
src/jsc/modules/minified_linkedjsdom.js Enhances DOM/timer/polyfill behavior and adds runtime globals expected by JS apps.
src/jsc/modules/linkedjsdomwrapper.js Exposes HTMLElement from window into the global scope for wrapper compatibility.
src/jsc/JavaScriptContext.cpp Updates dlsym symbols and injects Firebolt endpoint + DOM setup at startup when env var is set.
src/NativeJSRenderer.cpp Applies window.location setup for JSDOM as well as MiniJSDOM.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/jsc/modules/minified_linkedjsdom.js
Comment thread src/jsc/JavaScriptContext.cpp
Comment thread src/jsc/modules/minified_linkedjsdom.js
Comment thread src/jsc/modules/minified_linkedjsdom.js
Comment thread src/jsc/modules/linkedjsdomwrapper.js
@vjain008 vjain008 merged commit 236001b into develop Mar 18, 2026
8 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants