RDKEMW-3105 : Add ability to show network connections with details#18
Merged
Conversation
gurpreet319
force-pushed
the
topic/RDKEMW-3105
branch
from
954981d to
85b50e4
Compare
| { } | ||
|
|
||
| void setNetworkMetricsListener(NetworkMetricsListener* listener) | ||
| { |
Contributor
There was a problem hiding this comment.
We can add it in rtCore itself and not here
| #endif | ||
| JSContextGroupRef mContextGroup; | ||
| JSGlobalContextRef mContext; | ||
| rtMapObject* mObjectMap; |
Contributor
There was a problem hiding this comment.
please have valid name like mNetworkMetricsData
| if (mMetricsListener) | ||
| { | ||
| rtLogWarn("metriclistener"); | ||
| NetworkMetrics *metrics = new NetworkMetrics(); |
Contributor
There was a problem hiding this comment.
We should remove this object after calling onMetricsData
| } | ||
| } | ||
|
|
||
| rtLogWarn("Array object populated successfully."); |
|
|
||
| rtValue keys; | ||
| if (map->Get("allKeys", &keys) != RT_OK) { | ||
| rtLogWarn("Could not retrieve keys for the object map."); |
Contributor
There was a problem hiding this comment.
don;t have any prints telling map etc. Metion like network metrics data etc
madanagopalt
requested changes
Apr 29, 2025
Contributor
madanagopalt
left a comment
madanagopalt
left a comment
There was a problem hiding this comment.
kindly look at comments
gurpreet319
force-pushed
the
topic/RDKEMW-3105
branch
3 times, most recently
from
63cb2b5 to
4d21671
Compare
madanagopalt
reviewed
May 2, 2025
madanagopalt
reviewed
May 2, 2025
madanagopalt
requested changes
May 2, 2025
Contributor
madanagopalt
left a comment
madanagopalt
left a comment
There was a problem hiding this comment.
kindly look at comments
gurpreet319
force-pushed
the
topic/RDKEMW-3105
branch
4 times, most recently
from
164e88a to
fb52e48
Compare
madanagopalt
previously approved these changes
May 5, 2025
Reason for change: Added support for network metrics Test Procedure: build should be successful. Risks: low Priority: P2
gurpreet319
force-pushed
the
topic/RDKEMW-3105
branch
from
fb52e48 to
fbd44ec
Compare
vjain008
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added Support for network metrics
Test Procedure: build should be successful.
Risks: low
Priority: P2