Ticket Number :RDKEMW-3557:-Metrics for launchtime#19
Merged
Conversation
|
|
trupthi1403
force-pushed
the
topic/RDKEMW-3557
branch
from
19c5af5 to
133b7ae
Compare
Reason for change: Added timestamps and created structure to store it Test Procedure: timestamp logs must appear on wpeframework.log Risks: low Priority: P2
trupthi1403
force-pushed
the
topic/RDKEMW-3557
branch
from
133b7ae to
103a43f
Compare
|
|
||
| extern "C" JS_EXPORT void JSSynchronousGarbageCollectForDebugging(JSContextRef); | ||
|
|
||
| extern double getTimeInMilliSec(); |
| double executionEndTime=0.0; | ||
| double PlaybackStartTime=0.0; | ||
| }; | ||
| extern performanceMetrics metrics; |
Contributor
There was a problem hiding this comment.
Keep mPerformanceMetrics member variable within Context storing this data.
Change structure name as PerformanceMetrics
We don't want extern and variable metrics
madanagopalt
requested changes
Apr 23, 2025
Contributor
madanagopalt
left a comment
madanagopalt
left a comment
There was a problem hiding this comment.
kindly address comments
trupthi1403
force-pushed
the
topic/RDKEMW-3557
branch
from
f649ead to
453d094
Compare
| { | ||
| //execution start time | ||
| mPerformanceMetrics.executionStartTime = getTimeInMilliSec(); | ||
| std::cout << "\n-----EXECUTION_START_TIME-----: " << std::fixed << std::setprecision(3) << mPerformanceMetrics.executionStartTime<< " ms\n"; |
Contributor
There was a problem hiding this comment.
We don;t want this print
|
|
||
| //execution end time | ||
| mPerformanceMetrics.executionEndTime = getTimeInMilliSec(); | ||
| std::cout << "\n-----EXECUTION_END_TIME-----: " << std::fixed << std::setprecision(3) << mPerformanceMetrics.executionEndTime<< " ms\n"; |
Contributor
There was a problem hiding this comment.
We don;t want this print
| @@ -0,0 +1,9 @@ | |||
| #include<chrono> | |||
| @@ -0,0 +1,6 @@ | |||
| #ifndef TIME_UTILS_H | |||
| //for startTime | ||
| void setStartTime(double time){ | ||
| mPerformanceMetrics.startTime=time; | ||
| std::cout << "\n-----START TIME-----: " << std::fixed << std::setprecision(3) << time << " ms\n"; |
Contributor
There was a problem hiding this comment.
we don;t want this print
| mPerformanceMetrics.playbackStartTime = time; | ||
| std::cout << "\n-----PLAYBACK START TIME FROM CPP-----: " << std::fixed << std::setprecision(3) << time << " ms\n"; | ||
| double launchTime = mPerformanceMetrics.playbackStartTime-mPerformanceMetrics.startTime; | ||
| std::cout << "\n-----LAUNCH TIME FROM CPP-----: " << std::fixed << std::setprecision(3) << launchTime << " ms\n"; |
Contributor
There was a problem hiding this comment.
we don;t want this print
| //for playbackStartTime and launch Time calculation | ||
| void setPlaybackStartTime(double time) { | ||
| mPerformanceMetrics.playbackStartTime = time; | ||
| std::cout << "\n-----PLAYBACK START TIME FROM CPP-----: " << std::fixed << std::setprecision(3) << time << " ms\n"; |
Contributor
There was a problem hiding this comment.
we don;t want this print
madanagopalt
requested changes
Apr 29, 2025
Contributor
madanagopalt
left a comment
madanagopalt
left a comment
There was a problem hiding this comment.
Kindly look at comments. Add ticket number as part of PR
trupthi1403
force-pushed
the
topic/RDKEMW-3557
branch
from
453d094 to
6748deb
Compare
Reason for change: Aligned all collected timestamps and stored in structure Test Procedure: Timestamp logs must come on wpeframework log. Risks: low Priority: P2
trupthi1403
force-pushed
the
topic/RDKEMW-3557
branch
from
6748deb to
eca1c15
Compare
Contributor
Author
|
Commited with above required changes |
madanagopalt
previously approved these changes
Apr 29, 2025
Reason for change: Added timestamps and created structure to store it Test Procedure: timestamp logs must appear on wpeframework.log Risks: low Priority: P2
madanagopalt
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added timestamps and created structure to store it
Test Procedure: timestamp logs must appear on wpeframework.log
Risks: low
Priority: P2