RDKEMW-3523:Update rdkNativeScript with application identifiers by Sid2001-maker · Pull Request #20 · rdkcentral/rdkNativeScript

Sid2001-maker · 2025-04-30T10:06:30Z

Reason for change: Cleaned up the code
Test Procedure: build should be successful.
Risks: low
Priority: P2

CLAassistant · 2025-04-30T10:06:37Z

All committers have signed the CLA.

madanagopalt · 2025-05-05T08:42:31Z

+          RUNSCRIPT
+		    };
+
+        struct applicationRequest


Rename as ApplicationRequest

madanagopalt · 2025-05-05T08:43:21Z

-	};
-}
+                std::mutex mUserMutex;                                  	
+                struct applicationData{


Rename as ApplicationData

madanagopalt · 2025-05-07T06:45:05Z

        };
-
+
+        struct applicationDetails{


Change name to ApplicationDetails (any struct or class need to start with upper case for words within it)

madanagopalt · 2025-05-07T06:45:55Z

 #include <curl/curl.h>
 #include <JavaScriptEngine.h>
-#include <JavaScriptContext.h>
+//#include <JavaScriptContext.h>


Remove this commented line

madanagopalt · 2025-05-07T06:52:19Z

+    }

-    renderer->run();
+    std::this_thread::sleep_for(std::chrono::milliseconds(100));


can we avoid sleep?

madanagopalt

kindly look at comments

madanagopalt · 2025-05-09T07:05:25Z

+          bool mEnableJSDOM;
+          bool mEnableWindow;
+          bool mEnablePlayer;
+          //ModuleSettings mModuleSettings;


remove this commented line

changes done

madanagopalt · 2025-05-09T07:05:51Z

-	};
-}
+                std::mutex mUserMutex;                                  	
+                struct ApplicationData{


Move structure outisde the class

changes done

madanagopalt · 2025-05-09T07:07:20Z

 }

-void NativeJSRenderer::launchApplication(std::string url, ModuleSettings& moduleSettings)
+uint32_t createID()


Can we keep it as private member function within class as createApplicationIdentifier

changes done

madanagopalt

kindly look at comments

madanagopalt · 2025-05-09T07:11:32Z

+	if (mapEntry != mContextMap.end())
+	{
+		JavaScriptContext* context = (JavaScriptContext*)mContextMap[id].context;
+		std::string* Url = &mContextMap[id].url;


what is need for this line?

changes done

madanagopalt

kindly look at comments

madanagopalt · 2025-05-09T10:58:49Z

 }

-void NativeJSRenderer::launchApplication(std::string url, ModuleSettings& moduleSettings)
+uint32_t createApplicationIdentifier()


This needs to be NativeJSRenderer::::createApplicationIdentifier

changes done

madanagopalt · 2025-05-09T10:59:06Z

-    gPendingUrlRequests.push_back(request);
-    mUserMutex.unlock();
+    static uint32_t id = 1;
+    std::cout<<"Creating id: "<<id<<std::endl;


his print can be removed

changes done

madanagopalt · 2025-05-09T10:59:53Z

-    mUserMutex.unlock();
+    static uint32_t id = 1;
+    std::cout<<"Creating id: "<<id<<std::endl;
+    return id++;


Convert this line as:

uint32_t ret = id;
id++;
return ret;

madanagopalt · 2025-05-09T11:00:34Z

+			ApplicationDetails appData;
+			appData.id = key;
+			appData.url = value.url;
+			std::cout<<"Found application with ID: "<<key<<" and url:"<<value.url<<std::endl;


This print can be commented and mentioned as DEBUG level print. Same is applicable for print inside createApplication also

madanagopalt · 2025-05-09T11:02:15Z

+	uint32_t id= appRequest.mId;
+
+	JavaScriptContextFeatures features(mEmbedThunderJS, mEmbedRdkWebBridge, mEnableWebSocketServer, settings);
+        JavaScriptContext* context = new JavaScriptContext(features, " " , mEngine);


Give empty string. The string passed here as single space

madanagopalt · 2025-05-09T11:02:35Z

+        	std::cerr<<"context not created for id: "<< id <<std::endl;
+        	return ;
+        }
+        std::cout<<"Context created for id: "<<id<<std::endl;


Follow same as DEBUG comment

changes done

madanagopalt · 2025-05-09T11:04:09Z

-            loadApplication(gPendingUrlRequests[i].mUrl, settings);
+
+            ApplicationRequest& request = gPendingRequests[i];
+            if(request.mRequestType == 0)


Compare wtih ENUM name

changes done

madanagopalt · 2025-05-09T11:04:44Z

+            ApplicationRequest& request = gPendingRequests[i];
+            if(request.mRequestType == 0)
+            {
+		NativeJSRenderer::createApplicationInternal(request);


We don't want namespace here.

Changes done

madanagopalt

kindly look at comments

Reason for change: Cleaned up the code Test Procedure: build should be successful. Risks: low Priority: P2

Sid2001-maker requested a review from a team April 30, 2025 10:06

madanagopalt reviewed May 5, 2025

View reviewed changes

Sid2001-maker force-pushed the topic/RDKEMW-3523 branch 2 times, most recently from e4c61f9 to e54dbe2 Compare May 6, 2025 05:43

madanagopalt reviewed May 7, 2025

View reviewed changes

madanagopalt requested changes May 7, 2025

View reviewed changes

Sid2001-maker force-pushed the topic/RDKEMW-3523 branch 7 times, most recently from ba48605 to 4022c3c Compare May 9, 2025 06:27

madanagopalt reviewed May 9, 2025

View reviewed changes

madanagopalt requested changes May 9, 2025

View reviewed changes

madanagopalt reviewed May 9, 2025

View reviewed changes

madanagopalt requested changes May 9, 2025

View reviewed changes

Sid2001-maker force-pushed the topic/RDKEMW-3523 branch from 4022c3c to d8981ca Compare May 9, 2025 09:47

madanagopalt reviewed May 9, 2025

View reviewed changes

madanagopalt requested changes May 9, 2025

View reviewed changes

3523:Update rdkNativeScript with interface API's

60fc51b

Reason for change: Cleaned up the code Test Procedure: build should be successful. Risks: low Priority: P2

Sid2001-maker force-pushed the topic/RDKEMW-3523 branch from d8981ca to 60fc51b Compare May 9, 2025 12:00

madanagopalt approved these changes May 9, 2025

View reviewed changes

madanagopalt merged commit 6a346ef into develop May 9, 2025
3 of 4 checks passed

Sid2001-maker deleted the topic/RDKEMW-3523 branch February 18, 2026 09:26

Conversation

Sid2001-maker commented Apr 30, 2025

Uh oh!

CLAassistant commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madanagopalt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madanagopalt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madanagopalt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madanagopalt May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madanagopalt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

CLAassistant commented Apr 30, 2025 •

edited

Loading

madanagopalt May 9, 2025 •

edited

Loading