RDKEMW-3457 : WebSocket IPC#24
Merged
Merged
Conversation
|
|
gurpreet319
force-pushed
the
topic/RDKEMW-3457
branch
from
19f4056 to
f1e5aa7
Compare
madanagopalt
reviewed
May 9, 2025
| } | ||
| else | ||
| { | ||
| res = (uint32_t) itm->valuedouble; |
Contributor
There was a problem hiding this comment.
don't we have value number, something like that?
Contributor
Author
There was a problem hiding this comment.
we have valueint, but its DEPRECATED, mentioned in the documentation, and this valuedouble is used for number
https://github.com/DaveGamble/cJSON/blob/8f2beb57ddad1f94bed899790b00f46df893ccac/cJSON.h#L116C31-L116C41
madanagopalt
requested changes
May 9, 2025
Contributor
madanagopalt
left a comment
madanagopalt
left a comment
There was a problem hiding this comment.
Kindly look at comment.
gurpreet319
force-pushed
the
topic/RDKEMW-3457
branch
4 times, most recently
from
c2ba128 to
c0b4ef6
Compare
Reason for change: Added support for websocket IPC Test Procedure: build should be successful. Risks: low Priority: P2
gurpreet319
force-pushed
the
topic/RDKEMW-3457
branch
from
c0b4ef6 to
03cc02c
Compare
madanagopalt
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added support for websocket IPC
Test Procedure: build should be successful.
Risks: low
Priority: P2