Skip to content

RDKB-65287: Extend return value for unsupported HAL APIs#31

Merged
GoutamD2905 merged 9 commits into
developfrom
ghRDKB-65287-add-macro
Jun 4, 2026
Merged

RDKB-65287: Extend return value for unsupported HAL APIs#31
GoutamD2905 merged 9 commits into
developfrom
ghRDKB-65287-add-macro

Conversation

@biju-vi
Copy link
Copy Markdown
Contributor

@biju-vi biju-vi commented May 29, 2026

Reason for change: Add new macro for unsupported return type for all platforms
Test Procedure: NA
Risks: Low

Author: biju-vi biju.vijayanindiradevi@sky.uk

rdkcmf-jenkins and others added 5 commits September 25, 2025 18:25
Reason for change: Add new macro for unsupported return type
Test Procedure: NA
Risks: Low

Author: biju-vi  <biju.vijayanindiradevi@sky.uk>
Copilot AI review requested due to automatic review settings May 29, 2026 12:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new unsupported-return status for thermal manager HAL APIs and introduces a CLA workflow for pull request signature checks.

Changes:

  • Defines RETURN_UNSUPPORTED for thermal manager API return documentation.
  • Documents RETURN_UNSUPPORTED as a possible return value for several thermal manager HAL APIs.
  • Adds a GitHub Actions CLA workflow using the central RDK reusable workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
include/platform_hal.h Adds unsupported return-code macro and updates thermal manager API documentation.
.github/workflows/cla.yml Adds CLA signature-check workflow for PR and issue-comment events.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/platform_hal.h Outdated
Comment thread .github/workflows/cla.yml
@GoutamD2905 GoutamD2905 changed the base branch from main to develop June 1, 2026 10:23
Copy link
Copy Markdown
Contributor

@GoutamD2905 GoutamD2905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know why we need RETURN_UNSUPPORTED?

Is this platform-specific and required only for XB10 and XB9? If so, we should not add it to the generic HAL header. Instead, we should include it only in headers meant for specific platforms meta-layers as patches, and keep the generic headers limited to definitions supported across all Comcast platforms.

Reason for change: Add new macro for unsupported return type if a platform does not support that API
Test Procedure: NA
Risks: Low
Copilot AI review requested due to automatic review settings June 1, 2026 11:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread include/platform_hal.h
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@biju-vi
Copy link
Copy Markdown
Contributor Author

biju-vi commented Jun 1, 2026

May I know why we need RETURN_UNSUPPORTED?

Is this platform-specific and required only for XB10 and XB9? If so, we should not add it to the generic HAL header. Instead, we should include it only in headers meant for specific platforms meta-layers as patches, and keep the generic headers limited to definitions supported across all Comcast platforms.

Thermal Manager is going to be an open source code. So any third party who integrates thermal manager might need this return code if a specific HAL API is not supported on their platform

biju-vi added 2 commits June 2, 2026 11:34
Reason for change: Add new macro for unsupported return type if a platform does not support that API
Test Procedure: NA
Risks: Low
@biju-vi biju-vi changed the title RDKB-65287: Implement thermal manager HAL APIs for XB10 and XB9 RDKB-65287: Extend return value for unsupported HAL APIs Jun 3, 2026
@stn594
Copy link
Copy Markdown

stn594 commented Jun 4, 2026

May I know why we need RETURN_UNSUPPORTED?

Is this platform-specific and required only for XB10 and XB9? If so, we should not add it to the generic HAL header. Instead, we should include it only in headers meant for specific platforms meta-layers as patches, and keep the generic headers limited to definitions supported across all Comcast platforms.

@GoutamD2905,

This is not platform specific. If we return RETURN_ERR , then that error code will mislead thermal manager and it will log "error message". That error message will be flooding in xb9 and xb10. So we defined a new UNSUPPORTED macro to distinguish the dummy function.

@GoutamD2905 GoutamD2905 merged commit c554214 into develop Jun 4, 2026
4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants