RDKB-65287: Extend return value for unsupported HAL APIs#31
Conversation
Deploy cla action
…-cla Revert "Deploy cla action"
Reason for change: Add new macro for unsupported return type Test Procedure: NA Risks: Low Author: biju-vi <biju.vijayanindiradevi@sky.uk>
There was a problem hiding this comment.
Pull request overview
This PR adds a new unsupported-return status for thermal manager HAL APIs and introduces a CLA workflow for pull request signature checks.
Changes:
- Defines
RETURN_UNSUPPORTEDfor thermal manager API return documentation. - Documents
RETURN_UNSUPPORTEDas a possible return value for several thermal manager HAL APIs. - Adds a GitHub Actions CLA workflow using the central RDK reusable workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
include/platform_hal.h |
Adds unsupported return-code macro and updates thermal manager API documentation. |
.github/workflows/cla.yml |
Adds CLA signature-check workflow for PR and issue-comment events. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GoutamD2905
left a comment
There was a problem hiding this comment.
May I know why we need RETURN_UNSUPPORTED?
Is this platform-specific and required only for XB10 and XB9? If so, we should not add it to the generic HAL header. Instead, we should include it only in headers meant for specific platforms meta-layers as patches, and keep the generic headers limited to definitions supported across all Comcast platforms.
Reason for change: Add new macro for unsupported return type if a platform does not support that API Test Procedure: NA Risks: Low
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Thermal Manager is going to be an open source code. So any third party who integrates thermal manager might need this return code if a specific HAL API is not supported on their platform |
Reason for change: Add new macro for unsupported return type if a platform does not support that API Test Procedure: NA Risks: Low
This is not platform specific. If we return RETURN_ERR , then that error code will mislead thermal manager and it will log "error message". That error message will be flooding in xb9 and xb10. So we defined a new UNSUPPORTED macro to distinguish the dummy function. |
Reason for change: Add new macro for unsupported return type for all platforms
Test Procedure: NA
Risks: Low
Author: biju-vi biju.vijayanindiradevi@sky.uk