-
Notifications
You must be signed in to change notification settings - Fork 18
RDKPerf introduced in Rialto Server #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
balasaraswathy-n
wants to merge
12
commits into
master
Choose a base branch
from
feature/rdkemw-17139
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fb75e4e
Update main.cpp
balasaraswathy-n 4974a1b
Update main.cpp
balasaraswathy-n 8b0ec4e
Update CMakeLists.txt
balasaraswathy-n 9dfc574
Update main.cpp
balasaraswathy-n 66d18c8
Update CMakeLists.txt
balasaraswathy-n 98c8280
Update GstGenericPlayer.cpp
balasaraswathy-n 858f6fc
Update AttachSamples.cpp
balasaraswathy-n 5f8ed77
Merge branch 'master' into feature/rdkemw-17139
skywojciechowskim eeb74da
wrapper impl
skywojciechowskim 1789e36
ut/ct fix
skywojciechowskim 6cf5551
native build fix
skywojciechowskim 2bad508
native build fix 2
skywojciechowskim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -29,8 +29,10 @@ namespace firebolt::rialto::server::tasks::generic | |||||
| { | ||||||
| ReadShmDataAndAttachSamples::ReadShmDataAndAttachSamples( | ||||||
| GenericPlayerContext &context, const std::shared_ptr<firebolt::rialto::wrappers::IGstWrapper> &gstWrapper, | ||||||
| const std::shared_ptr<firebolt::rialto::wrappers::IRdkPerfWrapperFactory> &rdkPerfWrapperFactory, | ||||||
| IGstGenericPlayerPrivate &player, const std::shared_ptr<IDataReader> &dataReader) | ||||||
| : m_context{context}, m_gstWrapper{gstWrapper}, m_player{player}, m_dataReader{dataReader} | ||||||
| : m_context{context}, m_gstWrapper{gstWrapper}, m_rdkPerfWrapperFactory{rdkPerfWrapperFactory}, m_player{player}, | ||||||
| m_dataReader{dataReader} | ||||||
| { | ||||||
| RIALTO_SERVER_LOG_DEBUG("Constructing ReadShmDataAndAttachSamples"); | ||||||
| } | ||||||
|
|
@@ -43,6 +45,7 @@ ReadShmDataAndAttachSamples::~ReadShmDataAndAttachSamples() | |||||
| void ReadShmDataAndAttachSamples::execute() const | ||||||
| { | ||||||
| RIALTO_SERVER_LOG_DEBUG("Executing ReadShmDataAndAttachSamples"); | ||||||
| auto perf = m_rdkPerfWrapperFactory->createRdkPerfWrapper(__FUNCTION__); | ||||||
|
||||||
| auto perf = m_rdkPerfWrapperFactory->createRdkPerfWrapper(__FUNCTION__); | |
| [[maybe_unused]] auto perf = m_rdkPerfWrapperFactory->createRdkPerfWrapper(__FUNCTION__); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # | ||
| # If not stated otherwise in this file or this component's LICENSE file the | ||
| # following copyright and licenses apply: | ||
| # | ||
| # Copyright 2026 Sky UK | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| set( CMAKE_CXX_STANDARD 17 ) | ||
|
|
||
| set( CMAKE_CXX_STANDARD_REQUIRED ON ) | ||
| include( CheckCXXCompilerFlag ) | ||
| include( GNUInstallDirs ) | ||
| include(ExternalProject) | ||
|
|
||
| add_library( | ||
| rdkperf | ||
|
|
||
| STATIC | ||
| rdk_perf.cpp | ||
| ) | ||
|
|
||
| target_include_directories( | ||
| rdkperf | ||
|
|
||
| PUBLIC | ||
| . | ||
| ) | ||
|
|
||
| install ( | ||
| TARGETS rdkperf LIBRARY | ||
|
|
||
| DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
| * following copyright and licenses apply: | ||
| * | ||
| * Copyright 2026 Sky UK | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include "rdk_perf.h" | ||
|
|
||
| RDKPerf::RDKPerf(const char *szName) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
| * following copyright and licenses apply: | ||
| * | ||
| * Copyright 2026 Sky UK | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| class RDKPerf | ||
| { | ||
| public: | ||
| explicit RDKPerf(const char *szName); | ||
| ~RDKPerf() = default; | ||
| }; |
36 changes: 36 additions & 0 deletions
36
tests/common/externalLibraryMocks/RdkPerfWrapperFactoryMock.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
| * following copyright and licenses apply: | ||
| * | ||
| * Copyright 2026 Sky UK | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #ifndef FIREBOLT_RIALTO_WRAPPERS_RDK_PERF_WRAPPER_FACTORY_MOCK_H_ | ||
| #define FIREBOLT_RIALTO_WRAPPERS_RDK_PERF_WRAPPER_FACTORY_MOCK_H_ | ||
|
|
||
| #include "IRdkPerfWrapper.h" | ||
| #include <gmock/gmock.h> | ||
| #include <memory> | ||
|
|
||
| namespace firebolt::rialto::wrappers | ||
| { | ||
| class RdkPerfWrapperFactoryMock : public IRdkPerfWrapperFactory | ||
| { | ||
| public: | ||
| MOCK_METHOD(std::unique_ptr<IRdkPerfWrapper>, createRdkPerfWrapper, (const char *), (const, override)); | ||
| }; | ||
| } // namespace firebolt::rialto::wrappers | ||
|
|
||
| #endif // FIREBOLT_RIALTO_WRAPPERS_RDK_PERF_WRAPPER_FACTORY_MOCK_H_ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfis never used, and the repo builds with-Werror, so this will fail compilation due to-Wunused-variable. If the intent is RAII timing, mark it[[maybe_unused]]or explicitly cast to void while keeping it in scope.