Skip to content

RDKB-62887: Changing frequent logs to debug#27

Open
jayasrikadiyal wants to merge 8 commits into
developfrom
RDKB_62887
Open

RDKB-62887: Changing frequent logs to debug#27
jayasrikadiyal wants to merge 8 commits into
developfrom
RDKB_62887

Conversation

@jayasrikadiyal
Copy link
Copy Markdown

Reason for change: Modifying log to Debug.
Test Procedure: Tested by modfying log levl to Debug.
Adding screenshot of logs.
Risks: Low
Priority:P2
Signed-off-by:jayasri_kadiyala@comcast.com
image

Reason for change: Modifying log to Debug.
Test Procedure: Tested by modfying log levl to Debug.
Risks: Low
Priority:P2
Signed-off-by:jayasri_kadiyala@comcast.com
@jayasrikadiyal jayasrikadiyal requested a review from a team as a code owner May 13, 2026 23:29
Copilot AI review requested due to automatic review settings May 13, 2026 23:29
@jayasrikadiyal jayasrikadiyal requested a review from a team as a code owner May 13, 2026 23:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces selected SNMP-related log verbosity by changing frequent informational/warning traces to debug-level traces, and adds an ansc_platform.h include where CcspTraceDebug is now used.

Changes:

  • Converts SNMP GET call/success logs from info to debug.
  • Converts cache registration success logs from info to debug.
  • Converts several CCSP component-resolution failure logs from warning to debug.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
source/SnmpPlugin/cosa_api.c Demotes SNMP GET call/success logs to debug.
source/SnmpPlugin/ccsp_table_helper_control.c Demotes table cache registration success log to debug.
source/SnmpPlugin/ccsp_table_helper_access.c Demotes table cache component-resolution failure log to debug.
source/SnmpPlugin/ccsp_scalar_helper_control.c Demotes scalar cache registration success log to debug.
source/SnmpPlugin/ccsp_scalar_helper_access.c Demotes scalar cache component-resolution failure log to debug.
source/SnmpPlugin/ccsp_mib_utilities.c Demotes filter namespace component-resolution failure log to debug.
source/custom/ccsp_snmp_common.c Adds ansc_platform.h and demotes get/set DM component-resolution failures to debug.
Comments suppressed due to low confidence (1)

source/custom/ccsp_snmp_common.c:114

  • When set_dm_value cannot resolve the destination component it now returns -1 with no warning-level diagnostic from this helper. The generic caller only sees a failed set, so demoting the component-resolution failure to debug makes production troubleshooting harder for failed SNMP writes.
        CcspTraceDebug(("Failed to find the CCSP component who supports '%s'\n", param));

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/SnmpPlugin/ccsp_table_helper_access.c Outdated
Comment thread source/SnmpPlugin/ccsp_scalar_helper_access.c Outdated
Comment thread source/custom/ccsp_snmp_common.c Outdated
Comment thread source/SnmpPlugin/ccsp_mib_utilities.c Outdated
Reason for change: Modifying log to Debug.
Test Procedure: Tested by modfying log levl to Debug.
Risks: Low
Priority:P2
Signed-off-by:jayasri_kadiyala@comcast.com
GoutamD2905
GoutamD2905 previously approved these changes May 14, 2026
@jayasrikadiyal jayasrikadiyal requested a review from apattu200 May 14, 2026 16:39
Comment thread source/custom/ccsp_snmp_common.c Outdated
Comment thread source/custom/ccsp_snmp_common.c Outdated
Reverting Failed to find The ccsp component log to warning and Fixing the root cause to avoid failure messages.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 26, 2026 04:44
reverting change to fix root cause

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Comment thread source/custom/ccsp_snmp_common.c Outdated
Copilot AI review requested due to automatic review settings May 26, 2026 05:17
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Comment thread source/custom/ccsp_snmp_common.c Outdated
Copilot AI review requested due to automatic review settings May 26, 2026 05:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants