Skip to content

TDK-11955: MVS framework cleanup & fixes for app loading issue#191

Open
asuresh977 wants to merge 4 commits into
developfrom
feature/TDK-11955-MVS-Framework-Cleanup-And-Fixes
Open

TDK-11955: MVS framework cleanup & fixes for app loading issue#191
asuresh977 wants to merge 4 commits into
developfrom
feature/TDK-11955-MVS-Framework-Cleanup-And-Fixes

Conversation

@asuresh977
Copy link
Copy Markdown
Contributor

MVS framework cleanup & fixes for app loading issue [Sprint M149]

Reason for change: MVS Framework Updates
Test Procedure: Verify with TDK TM
Risks: None

…t M149]

Reason for change: MVS Framework Updates
Test Procedure: Verify with TDK TM
Risks: None
Signed-off-by: Aromal Suresh <aromal_suresh@comcast.com>
@asuresh977 asuresh977 requested a review from a team as a code owner June 2, 2026 06:51
Copilot AI review requested due to automatic review settings June 2, 2026 06:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up framework/fileStore/MediaValidationUtility.py by removing a number of legacy RDKShell-based helper functions (launchPlugin, destroyPlugin, moveToFrontClient, sendKeysToClient, checkRDKShellClients, checkClientZOrder, exclude_from_zorder, checkWebkitReadyState), normalizes whitespace, fixes a few typos in comments/messages, and reworks launchApp to retry the LoadedApps check (max 2 attempts with a 3-second sleep between them) to address an app-loading reliability issue.

Changes:

  • Remove legacy RDKShell helper functions and trim blank lines.
  • Refactor launchApp to poll rdkservice_get_loaded_apps() with a retry instead of a single 2-second wait.
  • Fix typos ("webnspect" → "webinspect", "webki webinspect" → "webinspect") and minor print formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread framework/fileStore/MediaValidationUtility.py
sahithya50
sahithya50 previously approved these changes Jun 2, 2026
sahithya50 and others added 2 commits June 2, 2026 14:12
…t M149]

Reason for change: MVS Framework Updates
Test Procedure: Verify with TDK TM
Risks: None
Signed-off-by: Aromal Suresh <aromal_suresh@comcast.com>
Copilot AI review requested due to automatic review settings June 2, 2026 08:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

…t M149]

Reason for change: MVS Framework Updates
Test Procedure: Verify with TDK TM
Risks: None
Signed-off-by: Aromal Suresh <aromal_suresh@comcast.com>
@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/tdk-core/191/rdk/tools/tdk

  • Commit: 81ac3c2

Report detail: gist'

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: OK

  • Commit: 81ac3c2
    '

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants