TDK-11528 ACL Test Coverage#194
Open
saniya-09 wants to merge 2 commits into
Open
Conversation
Reason for change: Added utiltiy functions for ACL test support Procedure: Test in BPI Risks: None
There was a problem hiding this comment.
Pull request overview
This PR adds new utility helpers intended to support WiFi ACL (MAC filtering) end-to-end testing by providing (1) prerequisite setup/revert across all radios and (2) WLAN client helpers for connecting to a specific BSSID and fetching the connected channel.
Changes:
- Added ACL prerequisite setup and revert helpers for all radios in
tdkutility.py. - Added WLAN client utilities to connect to an SSID+BSSID and to fetch MAC/channel info via SSH in
tdkbE2EUtility.py. - Extended the WLAN client shell script to support SSID+BSSID connect and fetching the connected channel.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| framework/fileStore/tdkutility.py | Adds ACL prerequisite and revert helpers for MAC filtering tests across radios. |
| framework/fileStore/tdkbE2EUtility.py | Adds WLAN client helpers for SSID+BSSID connect and channel/MAC retrieval. |
| framework/fileStore/tdkbE2EClientScripts/tdkbE2E_wlan.sh | Adds nmcli-based SSID+BSSID connect and connected-channel extraction commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1872
to
+1887
| preStatus = "SUCCESS" | ||
| expectedResult = "SUCCESS" | ||
| for index in range(1,4): | ||
| print(f"\n******For radio index : {index}*******") | ||
| step+=1 | ||
| param1 = "Device.WiFi.AccessPoint." + str(index) + ".X_CISCO_COM_MACFilter.Enable" | ||
| print(f"\nTEST STEP {step}: Set Mac Filter Enable {param1} to true.") | ||
| print(f"EXPECTED RESULT {step}: Should set Mac Filter Enable to true.") | ||
| tdkTestObj = obj.createTestStep("tdkb_e2e_Set") | ||
| tdkTestObj.addParameter("paramName",param1) | ||
| tdkTestObj.addParameter("paramValue","true") | ||
| tdkTestObj.addParameter("paramType","bool") | ||
| tdkTestObj.executeTestCase(expectedresult) | ||
| actualresult = tdkTestObj.getResult() | ||
| details = tdkTestObj.getResultDetails() | ||
| if expectedResult in actualresult: |
Comment on lines
+3206
to
+3208
| if ssidName in status: | ||
| status = wifiConnectBssid(ssidName,ssidPwd,bssid,securityType) | ||
| if wlan_2ghz_ssid_connect_status in status or wlan_5ghz_ssid_connect_status in status or wlan_6ghz_ssid_connect_status in status or wlan_2ghz_public_ssid_connect_status in status or wlan_5ghz_public_ssid_connect_status in status or wlan_6ghz_public_ssid_connect_status: |
Reason for change: Added ACL E2E tests Procedure: Test in BPI Risks: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added utiltiy functions for ACL test support
Procedure: Test in BPI
Risks: None