RDKEMW-15922: Coverity fix changes#29
Open
trupthi1403 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a set of Coverity-driven fixes across the westeros test/player apps and both GL/embedded renderers, primarily addressing type-safety, resource lifecycle, and file descriptor handling.
Changes:
- Fix integer overflow/format issues in
westeros-test.cpp(time calculation, printf specifiers) and add bounds checking for--delay. - Improve explicit-sync fence FD handling in both renderers and increase supported texture plane capacity (
MAX_TEXTURES). - Clean up fast-path module lifetime in embedded renderer and simplify player control-file handling via
remove().
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
westeros-test.cpp |
Safer time math, corrected logging format, and constrained --delay handling. |
westeros-render-gl.cpp |
Increase texture plane capacity and avoid close(-1) by guarding fence handling. |
westeros-render-embedded.cpp |
Increase texture plane capacity, prevent null deref in fast-path, and ensure dlclose() on teardown. |
westeros-player.cpp |
Replace stat()+remove() polling with remove() as the existence/action check. |
linux-expsync/westeros-linux-expsync.cpp |
Add <inttypes.h> to support PRI* format macros usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trupthi1403
force-pushed
the
topic/RDKEMW-15922
branch
from
1d988b7 to
c211654
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trupthi1403
force-pushed
the
topic/RDKEMW-15922
branch
from
0578bc6 to
1ecd6c5
Compare
Contributor
|
Changes look good to merge. |
Reason for change: Added coverity changes for linux-expsync/westeros-linux-expsync.cpp, westeros-player.cpp, westeros-render-embedded.cpp, westeros-render-gl.cpp, westeros-test.cpp Test Procedure: Refer Ticket Risks: Low Priority: P2
trupthi1403
force-pushed
the
topic/RDKEMW-15922
branch
from
1ecd6c5 to
99ab2f4
Compare
| delay= v; | ||
| printf("using delay=%d\n", delay ); | ||
| } | ||
| else if ( v >= 1000000 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added coverity fix changes for
linux-expsync/westeros-linux-expsync.cpp, westeros-player.cpp, westeros-render-embedded.cpp, westeros-render-gl.cpp, westeros-test.cpp
Test Procedure: Refer Ticket
Risks: Medium
Priority: P2