RDKEMW-16005-1: Resolve critical priority coverity issues#30
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Coverity-reported issues in the compositor around null dereference and safer temp-file cleanup logic.
Changes:
- Guard explicit-sync struct clearing in
wstSurfaceCreate()to avoid dereferencing a potentially-nullsurface. - Rework orphan temp-file pruning to open the candidate file with
O_NOFOLLOW, validate it viafstat, and remove it viaunlink.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trupthi1403
force-pushed
the
topic/RDKEMW-16005-1
branch
from
7e6a866 to
f7d643d
Compare
trupthi1403
force-pushed
the
topic/RDKEMW-16005-1
branch
from
f7d643d to
99c27cf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trupthi1403
force-pushed
the
topic/RDKEMW-16005-1
branch
from
99c27cf to
653d368
Compare
Contributor
|
Changes look good to merge. |
Reason for change: Changes to fix FORWARD_NULL, TOCTOU coverity issue Test Procedure: Refer Ticket Risks: Low Priority: P2
trupthi1403
force-pushed
the
topic/RDKEMW-16005-1
branch
from
653d368 to
50aaaae
Compare
sajnanazeer
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Changes to fix FORWARD_NULL, TOCTOU coverity issue
Test Procedure: Refer Ticket
Risks: Low
Priority: P2