RDKEMW-16005-3: Resolve medium priority coverity issues#31
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Coverity findings in the compositor by removing an unused value assignment and checking a previously unchecked return value.
Changes:
- Remove an unused
surfaceClientassignment inwstKeyboardSetFocus(addressesUNUSED_VALUE). - Check
remove()return value when deleting a temporary file and log an error on failure (addressesCHECKED_RETURN).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trupthi1403
force-pushed
the
topic/RDKEMW-16005-3
branch
from
d9f226a to
3a8d62d
Compare
trupthi1403
force-pushed
the
topic/RDKEMW-16005-3
branch
from
3a8d62d to
e0fe173
Compare
Contributor
|
Changes look good to merge. |
trupthi1403
force-pushed
the
topic/RDKEMW-16005-3
branch
from
e0fe173 to
ade4c31
Compare
Reason for change: Changes to fix CHECKED_RETURN, UNUSED_VALUE issues Test Procedure: Refer Ticket Risks: Low Priority: P2
trupthi1403
force-pushed
the
topic/RDKEMW-16005-3
branch
from
ade4c31 to
1532849
Compare
sajnanazeer
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Changes to fix CHECKED_RETURN, UNUSED_VALUE issues
Test Procedure: Refer Ticket
Risks: Low
Priority: P2