Add AWS Keyspace support using IAM temporary credentials#2
Open
ChaitanyaSingla wants to merge 3 commits into
Open
Add AWS Keyspace support using IAM temporary credentials#2ChaitanyaSingla wants to merge 3 commits into
ChaitanyaSingla wants to merge 3 commits into
Conversation
|
|
Sachin4403
suggested changes
Aug 28, 2024
| cluster.Keyspace = conf.GetString("xconfwebconfig.database.test_keyspace", DefaultTestKeyspace) | ||
| deviceKeyspace = conf.GetString("webconfig.database.device_test_keyspace", DefaultDeviceTestKeyspace) | ||
| isIamBasedAccessEnabled := conf.GetBoolean("xconfwebconfig.database.iam_based_access_enabled") | ||
| if isIamBasedAccessEnabled { |
There was a problem hiding this comment.
if someone want to access the AWS keyspace with AccessKey and SecretKey then there is no provision as of now. Can you enhance the same?
Author
There was a problem hiding this comment.
I have enhanced the same.
Sachin4403
approved these changes
Aug 30, 2024
|
Hi @gravi21 |
…ting to AWS Keyspace
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
|
Please close this PR and please create a New PR once you are ready with the code contribution. All the review comments discussed in a meeting was added to the RDKDEV ticket associated with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces IAM-based access for AWS keyspace functionality. The AWS SDK will now automatically retrieve the secret access key, access key ID and session token from the appropriate chain provider based on the specified AWS region. This retrieval is for the assumed role attached to the service's instance.
Along with this, Cassandra database port can be configured using the configuration.