Unittest coverage#75
Conversation
- Increase coverage for estb_firmware_handler.go functions - GetCheckMinFirmwareHandler: 71.9% → 100% (+28.1%) - GetEstbFirmwareVersionInfoPath: 69.7% → 100% (+30.3%) - Added comprehensive edge case tests for: * IP parsing paths (query param vs body) * Query parameter filtering (clientProtocol, cert expiry) * Body parameter parsing * Security token manager code path * Cert expiry handling * Multi-value query parameters * Application type extraction * MAC normalization Impact: - Main dataapi package: 51.1% → 52.2% (+1.1%) - Overall coverage: 38.2% → 38.9% (+0.7%) - 20 new test functions, all passing - Proper mocking to avoid DB/service dependencies Files: - dataapi/estb_firmware_handler_test.go: +20 tests - PROGRESS_SUMMARY_ESTB_FIRMWARE_HANDLER.md: detailed analysis
Mock coverage
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Please address my comment in PR#74 - the same "secrets" are here. |
|
@rdkcmf-jenkins @mhughesacn The tokens included in the test case files are sample values used solely for unit testing purposes. They are not real or production tokens. |
RahulRengeshOfficial
dismissed
vishnuajayccst’s stale review
The merge-base changed after approval.
|
Hi @RahulRengeshOfficial : Please will you add a comment in the affected files (sat_token_manager_test.go, group_service_connector_test.go) to say that all tokens are test values only. This can be a comment after the file header. This is important for future users, audits etc. - in effect, "We have considered that this value looks plausible but we are making it clear that it is not a real secret." |
4 participants
No description provided.