Add static application type initialization and related tests#94
Open
yeswanth2420 wants to merge 6 commits into
Open
Add static application type initialization and related tests#94yeswanth2420 wants to merge 6 commits into
yeswanth2420 wants to merge 6 commits into
Conversation
yeswanth2420
requested review from
bhushan-mdn,
gravi21 and
sanwar96
and removed request for
Copilot
gravi21
reviewed
Jan 23, 2026
gravi21
reviewed
Jan 23, 2026
There was a problem hiding this comment.
Pull request overview
This PR introduces dynamic application type management by replacing hardcoded validation logic with database-driven validation. The system now initializes predefined application types (STB, XHOME, SKY) in the database on startup and validates against this stored data using case-insensitive matching.
Changes:
- Added
InitializeStaticApplicationTypes()to create predefined application types on first run - Replaced hardcoded
isValid()with database-backedIsValidApplicationType()using case-insensitive matching - Introduced
GetAllApplicationTypeList()to retrieve all application types from the cached database - Added bootstrap call in
main.goto initialize static application types after API setup - Updated database schema with unrelated changes to PenetrationMetrics table and compression syntax
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| shared/coretypes.go | Added database-driven application type initialization and validation logic with three new functions |
| shared/coretypes_test.go | Removed tests for old hardcoded validation, modified existing tests (with issues) |
| main.go | Added bootstrap initialization call for static application types after XconfSetup |
| db/db_create_tables.cql | Contains unrelated schema changes (field renames and compression syntax update) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.