Craft Phase E: PR pipeline, CI Sonar, delivery docs

[rdryfoos]

Implements Craft Phase E (T088–T090; T087 scripted for post-merge).

What’s in

• T088 — .github/pull_request_template.md (task IDs, Traces, Gate 2 proof)
• T089 — CI job sonar via SonarSource/sonarqube-scan-action@v5 reading sonar-project.properties multicriteria
• T090 — Delivery workflow in craft-conventions.md + README; scripts/finish-phase-e.sh
• Tasks / dev-notes / sonar-disposition.md updated

Ops required before / after merge

1. Add repo secret SONAR_TOKEN (SonarCloud → My Account → Security → Generate Tokens). The new sonar job fails until this exists.
2. After first green CI Sonar scan: disable Automatic Analysis in SonarCloud so git suppressions stay authoritative.
3. After merge to main: run bash scripts/finish-phase-e.sh (admin) to require PRs + enforce_admins (T087).

Target flow

feature branch → PR → craft-gate + SonarCloud green → merge to main

  

[coderabbitai]

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ae9c6ae0-8aa3-4fab-a4fb-9a6eada2dad4

📥 Commits

Reviewing files that changed from the base of the PR and between ff2da2e and ed4bb05.

📒 Files selected for processing (9)

• .github/pull_request_template.md
• .github/workflows/ci.yml
• .sonarcloud.properties
• README.md
• scripts/finish-phase-e.sh
• specs/001-mvp/craft-conventions.md
• specs/001-mvp/dev-notes.md
• specs/001-mvp/sonar-disposition.md
• specs/001-mvp/tasks.md

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/craft-phase-e-pr-pipeline-7716

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud