Skip to content

Track Sonar coverage-wiring gap in dev-notes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdryfoos merged 2 commits into from
Jul 31, 2026
Merged

Track Sonar coverage-wiring gap in dev-notes #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32388c4
Track Sonar coverage-wiring gap in platform readiness.
cursoragent Jul 31, 2026
fe5789c
Cross-link Sonar coverage debt under Phase E notes.
cursoragent Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specs/001-mvp/dev-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ T076 (2026-07-03): `StructuralActionPolicy` implements AC-SYNC-07 — structural
| **Craft Phase C** | Tighten SwiftLint incrementally (re-enable size/complexity rules as files are split); optional `unused_parameter` as warning-as-error | **Next** (opportunistic) |
| **Craft Phase D** | SonarCloud suppressions (UI) + GitHub branch protection on `main` | **Done** (2026-07-08) |
| **Craft Phase E** | PR-only merge + PR template + CI-based Sonar scan | **In progress** — T088–T090 done; T087 via `finish-phase-e.sh` after merge |
| **Sonar coverage wiring** | Publish XCTest/xccov (or lcov) from the `ios` CI job into Sonar so “Coverage on New Code” is real | **Not started** — QG still requires ≥80% on new code; CI scan does not upload coverage yet, so `SonarCloud Code Analysis` fails with 0.0% (scan job itself can be green). Until wired: relax that QG condition, or accept the red check as known craft debt — not a Gate 2 / product failure |
| Observability | Sentry crash telemetry (DSN-gated via `SENTRY_DSN`) | **Done** — optional until TestFlight |
| Regression evals | Scripted sync/conflict scenario datasets in CI (SC-04 matrix) | **Done** — `SyncConflictMatrixTests` |

Expand Down Expand Up @@ -256,6 +257,8 @@ Pre-release sign-off: [`release-checklist.md`](./release-checklist.md) per `trac

Target flow: feature branch → open PR → `craft-gate` + Sonar green on PR → merge → `main` protected without bypass.

**Known follow-on (not Phase E scope):** Sonar quality gate “Coverage on New Code ≥ 80%” is unmet because CI does not yet publish Swift test coverage into Sonar — see Platform readiness row **Sonar coverage wiring**.

---

## Regenerating Xcode project
Expand Down
Loading