-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate HomesFlow to SpecAssay + display-name normalizer (FR-HOME-04 / AC-HOME-15) #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rdryfoos
wants to merge
2
commits into
main
Choose a base branch
from
claude/specassay-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,801
−357
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 0 additions & 34 deletions
34
...au-gate/.specify-dev/agent-commands/claude/speckit-clewseau-gate-check/SKILL.md
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
29 changes: 0 additions & 29 deletions
29
.specify/extensions/clewseau-gate/commands/speckit.clewseau-gate.check.md
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
34 changes: 34 additions & 0 deletions
34
...assay-check/.specify-dev/agent-commands/claude/speckit-specassay-check/SKILL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --- | ||
| name: speckit-specassay-check | ||
| description: Run SpecAssay Check (Gate 2) — fail on silent gaps; emit trace-manifest.json | ||
| compatibility: Requires spec-kit project structure with .specify/ directory | ||
| metadata: | ||
| author: github-spec-kit | ||
| source: specassay-check:commands/speckit.specassay.check.md | ||
| --- | ||
|
|
||
| # SpecAssay Check (Gate 2) | ||
|
|
||
| Run the portable Gate 2 script shipped with this extension. It checks that: | ||
|
|
||
| - registry IDs ≡ IDs in specs ≡ IDs in tasks (**exact-set** drift), | ||
| - durable IDs are either verified (named proof) or tracked as debt (open task) for **ACs**, | ||
| - coverage annotations / test-encoded IDs are not orphans, | ||
| - checkbox tasks declare `Carries:`, | ||
|
|
||
| and **always writes `trace-manifest.json`** (path configurable) — the SpecAssay matrix. The manifest is written even when the gate fails, so GAPs and `gate.failures` are visible. | ||
|
|
||
| `trace-manifest.json` is portable and vendor-neutral (`format: "trace-manifest"`, schemaVersion 3). It is not ReqIF/OSLC. Loupe (the viewer) consumes this file; it does not re-scan the target. | ||
|
|
||
| ## Steps | ||
|
|
||
| 1. Confirm `.specify/extensions/specassay-check/specassay-check-config.yml` exists (copy from `config-template.yml` if missing) and points at this project's registry, specs, tasks, and source/test trees. Set `manifest_path` if you do not want `trace-manifest.json` at the project root. | ||
| 2. From the project root, run: | ||
|
|
||
| ```bash | ||
| bash .specify/extensions/specassay-check/scripts/check-traceability.sh | ||
| ``` | ||
|
|
||
| 3. Report the script's exit code, any `FAIL:` lines, and confirm `trace-manifest.json` (or configured `manifest_path`) was written. | ||
| 4. Do **not** weaken the gate. If something is unfinished, it belongs as tracked debt (unchecked task with `Carries:`), not as a silenced gap. | ||
| 5. Reminder: **verified** means a named proof exists — not that a full suite was asserted green by this script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # SpecAssay Check | ||
|
|
||
| Every **wish** is on the **Golden Thread** with its **work** and its **proof**; this check stops the line at any loose end, then strikes a hallmark on what it found — the **trace-manifest**. | ||
|
|
||
| Gate 2: compare the ID registry to specs, tasks, coverage annotations, and test names. **Exact-set** registry ≡ specs ≡ tasks. Silent AC gaps and untraced scope fail. **Always writes a trace-manifest** (default `trace-manifest.json`, configurable via `manifest_path`) for Loupe or any matrix consumer. | ||
|
|
||
| **CI is the property line.** Run this script on every PR / protected-branch push and fail the build on non-zero exit. Local runs are hygiene; CI is what stops a cowboy (or any machine without SpecAssay) from merging unmarked work. Keep the emitted trace-manifest from the CI run as evidence. | ||
|
|
||
| Install: | ||
|
|
||
| ```bash | ||
| specify extension add --dev /path/to/specassay/extensions/specassay-check | ||
| ``` | ||
|
|
||
| Install scaffolds `specassay-check-config.yml` from `config-template.yml`. Edit `registry`, `manifest_path`, `specs`, `tasks`, `src_globs`, and `test_globs` for your repo. |
29 changes: 29 additions & 0 deletions
29
.specify/extensions/specassay-check/commands/speckit.specassay.check.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| description: Run SpecAssay Check (Gate 2) — fail on silent gaps; emit trace-manifest.json | ||
| --- | ||
|
|
||
| # SpecAssay Check (Gate 2) | ||
|
|
||
| Run the portable Gate 2 script shipped with this extension. It checks that: | ||
|
|
||
| - registry IDs ≡ IDs in specs ≡ IDs in tasks (**exact-set** drift), | ||
| - durable IDs are either verified (named proof) or tracked as debt (open task) for **ACs**, | ||
| - coverage annotations / test-encoded IDs are not orphans, | ||
| - checkbox tasks declare `Carries:`, | ||
|
|
||
| and **always writes a trace-manifest** (default `trace-manifest.json`, path configurable) — the SpecAssay matrix. The manifest is written even when the gate fails, so GAPs and `gate.failures` are visible. | ||
|
|
||
| `trace-manifest.json` is a portable, vendor-neutral matrix (`format: "trace-manifest"`, schemaVersion 3). It is not ReqIF/OSLC. Loupe (the viewer) consumes this file; it does not re-scan the target. | ||
|
|
||
| ## Steps | ||
|
|
||
| 1. Confirm `.specify/extensions/specassay-check/specassay-check-config.yml` exists (copy from `config-template.yml` if missing) and points at this project's registry, specs, tasks, and source/test trees. Set `manifest_path` if you do not want `trace-manifest.json` at the project root. | ||
| 2. From the project root, run: | ||
|
|
||
| ```bash | ||
| bash .specify/extensions/specassay-check/scripts/check-traceability.sh | ||
| ``` | ||
|
|
||
| 3. Report the script's exit code, any `FAIL:` lines, and confirm `trace-manifest.json` (or configured `manifest_path`) was written. | ||
| 4. Do **not** weaken the gate. If something is unfinished, it belongs as tracked debt (unchecked task with `Carries:`), not as a silenced gap. | ||
| 5. Reminder: **verified** means a named proof exists — not that a full suite was asserted green by this script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| schema_version: "1.0" | ||
|
|
||
| extension: | ||
| id: "specassay-check" | ||
| name: "SpecAssay Check" | ||
| version: "0.2.0" | ||
| description: "Gate 2 — refuse silent gaps and emit a trace-manifest (`trace-manifest.json`)." | ||
| category: "visibility" | ||
| effect: "read-write" | ||
| author: "Rik Dryfoos / Dryfoos Consulting" | ||
| license: "MIT" | ||
| homepage: "https://github.com/rdryfoos/specassay" | ||
| repository: "https://github.com/rdryfoos/specassay" | ||
|
|
||
| requires: | ||
| speckit_version: ">=0.14.0" | ||
| tools: [] | ||
|
|
||
| provides: | ||
| commands: | ||
| - name: "speckit.specassay.check" | ||
| file: "commands/speckit.specassay.check.md" | ||
| description: "Run SpecAssay Check / Gate 2 (silent gaps fail; write trace-manifest.json)" | ||
|
|
||
| config: | ||
| - name: "specassay-check-config.yml" | ||
| template: "config-template.yml" | ||
| description: "Registry path, source/test globs, and ID grammar" | ||
| required: true | ||
|
|
||
| hooks: | ||
| after_implement: | ||
| command: "speckit.specassay.check" | ||
| optional: true | ||
| prompt: "Run SpecAssay Check (Gate 2 traceability)?" | ||
| description: "Refuse silent gaps after implementation; refresh trace-manifest.json" | ||
|
|
||
| tags: | ||
| - "traceability" | ||
| - "gate" | ||
| - "ci" | ||
| - "governance" | ||
| - "sdd" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: rdryfoos/HomesFlow
Length of output: 3410
Use valid YAML quoting for
carries_regex.\*is not a valid double-quoted YAML escape, so these files fail to parse; use a single-quoted scalar instead..specify/extensions/specassay-check/config-template.yml#L30-L32.specify/extensions/specassay-check/specassay-check-config.yml#L13Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 31-31: syntax error: found unknown escape character '*'
(syntax)
📍 Affects 2 files
.specify/extensions/specassay-check/config-template.yml#L30-L32(this comment).specify/extensions/specassay-check/specassay-check-config.yml#L13-L13🤖 Prompt for AI Agents
Source: Linters/SAST tools