Demo (broken thread): close the debt task without adding the proof - #2
Demo (broken thread): close the debt task without adding the proof#2rdryfoos wants to merge 2 commits into
Conversation
A developer marks T005 done and moves it to Completed, but never adds the disjoint-field merge test. AC-SYNC-02 now has no proof and no open Carries TODO, so the Gate refuses it as a silent gap (GAP). This is the deliberate 'broken thread' subject for the Thread Report red-state walkthrough — the report posts and explains the break; the Gate verdict step blocks the merge. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TM5e4tKiqCUNANBCkTtH2r
🧵 Thread Report🔴 Golden Thread broken What moved
Thread StatusSYNC
+2 untouched backlog rows not shown. Off ThreadEvery changed file carries a mark tying it to an intent. Nothing sits off the thread. Thread Report illuminates; it does not refuse. "Off thread" is a visibility call, not a gate. Set |
…ks, broken path, real offthread_ack) Rewrites docs/thread-report.md for the shipped v2: the single-line gate header, clickable diff-hunk/registry links (with the sha256 anchor + blob fallback note), hidden untouched-backlog rows, the broken path (post the report, then block via a separate verdict step), and offthread_ack as a real config key. Cross-links both live demos — green PR #1 and broken PR #2. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TM5e4tKiqCUNANBCkTtH2r
📝 WalkthroughWalkthroughThe sync task specification moves T005 from tracked debt to Completed and retains its ChangesSync task status
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/example-app/specs/sync/tasks.md`:
- Line 12: Align T005’s completion status with the AC-SYNC-02 proof: add the
promised disjoint-field merge test and remove the related open TODO, or uncheck
T005 and keep it tracked as incomplete until that proof exists.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 79c92efd-fb05-4d39-a217-359574fc5766
📒 Files selected for processing (1)
examples/example-app/specs/sync/tasks.md
| ## Tracked debt | ||
|
|
||
| - [ ] T005 Field-level merge test for disjoint edits — **Carries**: AC-SYNC-02 — deferred to the sync milestone | ||
| - [x] T005 Field-level merge test for disjoint edits — **Carries**: AC-SYNC-02 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Do not mark T005 completed without the AC-SYNC-02 proof.
examples/example-app/tests/test_sync.py:1-11 states that AC-SYNC-02 is not proved and remains tracked debt under T005. This line creates a false completion state and a silent acceptance gap. Add the promised disjoint-field merge test and remove the open TODO, or keep T005 under tracked debt until the proof exists.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@examples/example-app/specs/sync/tasks.md` at line 12, Align T005’s completion
status with the AC-SYNC-02 proof: add the promised disjoint-field merge test and
remove the related open TODO, or uncheck T005 and keep it tracked as incomplete
until that proof exists.
This PR is a deliberate demonstration of a broken Golden Thread — the red counterpart to the green #1. It exists so the Thread Report's broken state is a real, live artifact.
What it does
A developer marks the tracked-debt task
T005as done and moves it into Completed — but never writes the disjoint-field merge test it promised. SoAC-SYNC-02now has:test_AC_SYNC_02_*), andCarries:TODO excusing it.That is a silent gap: an acceptance criterion with nothing standing behind it. Gate 2 refuses it (
AC-SYNC-02→GAP).What you should see
🔴 Golden Thread broken, showingAC-SYNC-02: tracked-debt → GAP ⬇— it illuminates the break in thread terms.Gate verdictstep then fails the check — that ✗ is the block. The comment is never the block.Not intended to merge; it's the walkthrough's broken specimen.
Generated by Claude Code
Summary by CodeRabbit