Skip to content

Demo (broken thread): close the debt task without adding the proof - #2

Open
rdryfoos wants to merge 2 commits into
mainfrom
demo/break-sync-gap
Open

Demo (broken thread): close the debt task without adding the proof#2
rdryfoos wants to merge 2 commits into
mainfrom
demo/break-sync-gap

Conversation

@rdryfoos

@rdryfoos rdryfoos commented Aug 10, 2026

Copy link
Copy Markdown
Owner

This PR is a deliberate demonstration of a broken Golden Thread — the red counterpart to the green #1. It exists so the Thread Report's broken state is a real, live artifact.

What it does

A developer marks the tracked-debt task T005 as done and moves it into Completed — but never writes the disjoint-field merge test it promised. So AC-SYNC-02 now has:

  • no proof (test_AC_SYNC_02_*), and
  • no open Carries: TODO excusing it.

That is a silent gap: an acceptance criterion with nothing standing behind it. Gate 2 refuses it (AC-SYNC-02GAP).

What you should see

  • The Thread Report comment posts anyway, headed 🔴 Golden Thread broken, showing AC-SYNC-02: tracked-debt → GAP ⬇ — it illuminates the break in thread terms.
  • A separate Gate verdict step then fails the check — that ✗ is the block. The comment is never the block.

Not intended to merge; it's the walkthrough's broken specimen.


Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Marked the field-level merge test for disjoint edits as completed in the task tracking documentation.

A developer marks T005 done and moves it to Completed, but never adds the
disjoint-field merge test. AC-SYNC-02 now has no proof and no open Carries
TODO, so the Gate refuses it as a silent gap (GAP). This is the deliberate
'broken thread' subject for the Thread Report red-state walkthrough — the
report posts and explains the break; the Gate verdict step blocks the merge.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TM5e4tKiqCUNANBCkTtH2r
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

🧵 Thread Report

🔴 Golden Thread broken

What moved

Thread Status

SYNC

ID Status
AC-SYNC-01 🟢 proven
AC-SYNC-02 🔴 GAP ◀ changed

+2 untouched backlog rows not shown.

Off Thread

Every changed file carries a mark tying it to an intent. Nothing sits off the thread.


Thread Report illuminates; it does not refuse. "Off thread" is a visibility call, not a gate. Set offthread_ack: record|required in the SpecAssay config to add a human tick.

rdryfoos pushed a commit that referenced this pull request Aug 10, 2026
…ks, broken path, real offthread_ack)

Rewrites docs/thread-report.md for the shipped v2: the single-line gate
header, clickable diff-hunk/registry links (with the sha256 anchor + blob
fallback note), hidden untouched-backlog rows, the broken path (post the
report, then block via a separate verdict step), and offthread_ack as a real
config key. Cross-links both live demos — green PR #1 and broken PR #2.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TM5e4tKiqCUNANBCkTtH2r
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The sync task specification moves T005 from tracked debt to Completed and retains its AC-SYNC-02 registry mark.

Changes

Sync task status

Layer / File(s) Summary
Record T005 completion
examples/example-app/specs/sync/tasks.md
Moves T005 to Completed and retains its AC-SYNC-02 registry mark.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the deliberate broken-thread demonstration and the change to close the debt task without adding proof.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch demo/break-sync-gap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@examples/example-app/specs/sync/tasks.md`:
- Line 12: Align T005’s completion status with the AC-SYNC-02 proof: add the
promised disjoint-field merge test and remove the related open TODO, or uncheck
T005 and keep it tracked as incomplete until that proof exists.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 79c92efd-fb05-4d39-a217-359574fc5766

📥 Commits

Reviewing files that changed from the base of the PR and between f1edee1 and 644af64.

📒 Files selected for processing (1)
  • examples/example-app/specs/sync/tasks.md

## Tracked debt

- [ ] T005 Field-level merge test for disjoint edits — **Carries**: AC-SYNC-02 — deferred to the sync milestone
- [x] T005 Field-level merge test for disjoint edits — **Carries**: AC-SYNC-02

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Do not mark T005 completed without the AC-SYNC-02 proof.

examples/example-app/tests/test_sync.py:1-11 states that AC-SYNC-02 is not proved and remains tracked debt under T005. This line creates a false completion state and a silent acceptance gap. Add the promised disjoint-field merge test and remove the open TODO, or keep T005 under tracked debt until the proof exists.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/example-app/specs/sync/tasks.md` at line 12, Align T005’s completion
status with the AC-SYNC-02 proof: add the promised disjoint-field merge test and
remove the related open TODO, or uncheck T005 and keep it tracked as incomplete
until that proof exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants