Skip to content

Demo (intent restated): tighten the sync SLA from 5s to 3s #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdryfoos wants to merge 4 commits into
base: main
Choose a base branch
from
+1 −1
Open

Demo (intent restated): tighten the sync SLA from 5s to 3s #3

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09d58ad
example-app demo (intent restated): tighten AC-SYNC-01 SLA 5s → 3s
claude Aug 10, 2026
203c91b
Merge branch 'main' into demo/restate-intent
claude Aug 10, 2026
ce1da19
Merge branch 'main' into demo/restate-intent
claude Aug 10, 2026
c5cef95
Merge branch 'main' into demo/restate-intent
claude Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/example-app/PRD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ an open `- [ ] … **Carries**:` TODO).

- US-SYNC-01 — As a user, I keep my lists in sync across devices.
- FR-SYNC-01 — Two-way sync reconciles list changes across devices.
- AC-SYNC-01 — A change made offline appears on a second device within 5s of reconnect.
- AC-SYNC-01 — A change made offline appears on a second device within 3s of reconnect.

@coderabbitai coderabbitai Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Update the AC-SYNC-01 proof to enforce 3 seconds.

examples/example-app/tests/test_sync.py:18-37 still asserts elapsed < 5.0. The gate can therefore pass an implementation that takes 4 seconds. Change the assertion and comment to 3 seconds, then re-confirm examples/example-app/src/sync.py:51 against the tightened SLA.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/example-app/PRD.md` at line 14, Update the AC-SYNC-01 proof in
test_sync.py to assert reconnection synchronization completes in under 3.0
seconds and revise its accompanying comment to match. Then verify the
implementation at sync.py’s synchronization path satisfies the tightened
3-second SLA.

- AC-SYNC-02 — Disjoint field edits on two devices merge without conflict.
- AC-OFFL-01 — The app is fully usable with no network; edits queue locally.

Expand Down
Loading