fix(test): remove bare t.Skip() without linked issue (#540)

[nextlevelshit]

Summary

• Removed TestContractPrompt_SymlinkBlocking test which contained only a bare t.Skip() with no linked issue
• This violates the constraint in CLAUDE.md: "No t.Skip() without a linked issue"
• All tests pass after removal

Test plan

• go test -race ./... passes

[nextlevelshit]

Code Review (Wave Pipeline)

Verdict: APPROVE

Overall Assessment

PR #543 removes an empty test stub (TestContractPrompt_SymlinkBlocking) that contained a bare t.Skip() without a linked issue — a direct violation of the project's No t.Skip() without a linked issue policy. The fix is correct: the stub tested nothing, no symlink-blocking implementation exists in the codebase, and deletion is the right resolution. Spec documentation is included under specs/540-fix-skip-linked-issue/.

Critical Issues

None.

Suggested Improvements

• Remaining t.Skip() audit (informational): ~24 t.Skip() calls remain in the codebase. All are conditional skips guarded by runtime checks (tool availability, platform support), which is the valid pattern. No action required — this confirms no other bare-skip violations exist.

Positive Observations

• Clean, minimal change — 5 lines removed, no collateral edits
• Tests pass (go test ./internal/pipeline/... — 24.3s, PASS)
• Surrounding test functions (TestContractPrompt_UnicodeInSchema, TestContractPrompt_SecurityLogging) verified unaffected
• Spec documentation follows established specs/ directory convention
• Zero security impact — no production code, configuration, or runtime behavior changed

---

Generated by Wave pr-review pipeline