Changes the order of fixed and other properties in flatColumns#1302
Changes the order of fixed and other properties in flatColumns#1302ryantang247 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough本次更改调整了 Changes
Sequence Diagram(s)sequenceDiagram
participant ParentColumn
participant SubColumn
participant flatColumns
ParentColumn->>flatColumns: 传递 columns(含 fixed 属性)
flatColumns->>SubColumn: 遍历 children,合并属性
flatColumns-->>SubColumn: 用父列 fixed 覆盖子列 fixed
flatColumns->>flatColumns: 返回合并后的列数组
Assessment against linked issues
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/hooks/useColumns/index.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. The config "prettier" was referenced from the config file in "/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learningssrc/hooks/useColumns/index.tsx (1)🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes https://github.com/ant-design/ant-design/issues/51812
A similar issue can be found in the example from https://table-react-component.vercel.app/demo/fixed-columns-and-header-rtl, where Fix Left and Fix title3 should make the parent column fixed, but the child columns are not responding.
In the function mentioned, the property wasn't inherited due to misordering of the properties of column.
Summary by CodeRabbit