fix: fix tableLayout of sticky table header#1316
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
13a3985 to
d691d8f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the table layout issue for sticky table headers by properly passing the tableLayout property to the FixedHolder components. The fix ensures that sticky headers and summaries respect the configured table layout instead of being hardcoded to 'fixed'.
- Adds
tableLayoutprop to the FixedHolder component interface - Updates FixedHolder to use the passed
tableLayoutinstead of hardcoded 'fixed' - Passes
mergedTableLayoutto both header and summary FixedHolder instances
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Table.tsx | Passes mergedTableLayout to header and summary FixedHolder components |
| src/FixedHolder/index.tsx | Adds tableLayout prop and uses it instead of hardcoded 'fixed' value |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1316 +/- ##
=========================================
Coverage 97.74% 97.74%
=========================================
Files 77 77
Lines 7635 7638 +3
Branches 1158 1158
=========================================
+ Hits 7463 7466 +3
Misses 166 166
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ant-design/ant-design#54741