Skip to content

fix: fix tableLayout of sticky table header#1316

Closed
afc163 wants to merge 2 commits into
antd-5.xfrom
fix/sticky-table-header-fixed-layout
Closed

fix: fix tableLayout of sticky table header#1316
afc163 wants to merge 2 commits into
antd-5.xfrom
fix/sticky-table-header-fixed-layout

Conversation

@afc163
Copy link
Copy Markdown
Member

@afc163 afc163 commented Aug 26, 2025

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
table Ready Ready Preview Comment Aug 26, 2025 3:35am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 26, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sticky-table-header-fixed-layout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@afc163 afc163 changed the base branch from master to antd-5.x August 26, 2025 03:31
@afc163 afc163 changed the title fix: cherry pick of fixing sticky issue (#1232) fix: add tableLayout prop to FixedHolder and pass it to TableComponent Aug 26, 2025
@afc163 afc163 changed the title fix: add tableLayout prop to FixedHolder and pass it to TableComponent fix: fix tableLayout of sticky table header Aug 26, 2025
@afc163 afc163 requested a review from Copilot August 26, 2025 03:32

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the table layout issue for sticky table headers by properly passing the tableLayout property to the FixedHolder components. The fix ensures that sticky headers and summaries respect the configured table layout instead of being hardcoded to 'fixed'.

  • Adds tableLayout prop to the FixedHolder component interface
  • Updates FixedHolder to use the passed tableLayout instead of hardcoded 'fixed'
  • Passes mergedTableLayout to both header and summary FixedHolder instances

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Table.tsx Passes mergedTableLayout to header and summary FixedHolder components
src/FixedHolder/index.tsx Adds tableLayout prop and uses it instead of hardcoded 'fixed' value

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.74%. Comparing base (3916bd3) to head (d691d8f).

Additional details and impacted files
@@            Coverage Diff            @@
##           antd-5.x    #1316   +/-   ##
=========================================
  Coverage     97.74%   97.74%           
=========================================
  Files            77       77           
  Lines          7635     7638    +3     
  Branches       1158     1158           
=========================================
+ Hits           7463     7466    +3     
  Misses          166      166           
  Partials          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@afc163 afc163 closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants