Skip to content

feat: add ShadowComponent to encapsulate shadow DOM rendering in tabl… #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afc163 wants to merge 3 commits into from
Closed

feat: add ShadowComponent to encapsulate shadow DOM rendering in tabl… #1366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71d2f85
feat: add ShadowComponent to encapsulate shadow DOM rendering in tabl…
afc163 Sep 22, 2025
698a066
test: update snapshot tests for table measure cell content changes
afc163 Sep 22, 2025
b848ca1
feat: add shadow dom support check and fallback rendering
afc163 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Body/MeasureCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as React from 'react';
import ResizeObserver from 'rc-resize-observer';
import useLayoutEffect from 'rc-util/lib/hooks/useLayoutEffect';
import ShadowComponent from './ShadowComponent';
import type { ColumnType } from '../interface';

export interface MeasureCellProps {
Expand All @@ -27,7 +28,9 @@ export default function MeasureCell({
return (
<ResizeObserver data={columnKey}>
<th ref={cellRef} className={`${prefixCls}-measure-cell`}>
<div className={`${prefixCls}-measure-cell-content`}>{column?.title || '\xa0'}</div>
<ShadowComponent className={`${prefixCls}-measure-cell-content`}>
{column?.title || '\xa0'}
</ShadowComponent>
</th>
</ResizeObserver>
);
Expand Down
45 changes: 45 additions & 0 deletions src/Body/ShadowComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import * as React from 'react';
import { createPortal } from 'react-dom';

function isShadowDomSupported() {
return typeof window !== 'undefined' && !!HTMLElement.prototype.attachShadow;
}

export default function ShadowComponent({
children,
className,
}: {
children: React.ReactNode;
className: string;
}) {
const hostRef = React.useRef<HTMLDivElement>(null);
const [shadowRoot, setShadowRoot] = React.useState<ShadowRoot | null>(null);
const [shadowSupported, setShadowSupported] = React.useState<boolean>(true);

React.useEffect(() => {
// 检查是否支持 Shadow DOM
if (!isShadowDomSupported()) {
setShadowSupported(false);
return;
}
if (hostRef.current && !shadowRoot) {
const shadow = hostRef.current.attachShadow({ mode: 'open' });
setShadowRoot(shadow);
}
}, [shadowRoot]);

// 如果不支持 Shadow DOM，直接渲染 children
if (!shadowSupported) {
return (
<div ref={hostRef} className={className}>
{children}
</div>
);
}

return (
<div ref={hostRef} className={className}>
{shadowRoot && createPortal(children, shadowRoot)}
</div>
);
}
80 changes: 20 additions & 60 deletions tests/__snapshots__/ExpandRow.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,36 +195,28 @@ LoadedCheerio {
>
<div
class="rc-table-measure-cell-content"
>

</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Name
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Age
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Gender
</div>
/>
</th>
</tr>
<tr
Expand Down Expand Up @@ -380,36 +372,28 @@ LoadedCheerio {
>
<div
class="rc-table-measure-cell-content"
>

</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Name
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Age
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Gender
</div>
/>
</th>
</tr>
<tr
Expand Down Expand Up @@ -683,36 +667,28 @@ LoadedCheerio {
>
<div
class="rc-table-measure-cell-content"
>

</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Name
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Age
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Gender
</div>
/>
</th>
</tr>
<tr
Expand Down Expand Up @@ -1237,36 +1213,28 @@ LoadedCheerio {
>
<div
class="rc-table-measure-cell-content"
>

</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Name
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Age
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Gender
</div>
/>
</th>
</tr>
<tr
Expand Down Expand Up @@ -1425,36 +1393,28 @@ LoadedCheerio {
>
<div
class="rc-table-measure-cell-content"
>
Name
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Age
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>
Gender
</div>
/>
</th>
<th
class="rc-table-measure-cell"
>
<div
class="rc-table-measure-cell-content"
>

</div>
/>
</th>
</tr>
<tr
Expand Down
Loading