docs(ui-components): add Pressable component documentation#4049
Closed
aymenhamada wants to merge 1 commit into
Closed
docs(ui-components): add Pressable component documentation#4049aymenhamada wants to merge 1 commit into
aymenhamada wants to merge 1 commit into
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Abbondanzo
requested changes
Dec 2, 2024
Abbondanzo
left a comment
Abbondanzo
left a comment
Contributor
There was a problem hiding this comment.
One minor nit on phrasing. Also, could you copy these changes to each of the more recent versions + the version in the docs folder so it's included on future releases? Thanks!
| <div className="component"> | ||
| <a href="./pressable"> | ||
| <h3>Pressable</h3> | ||
| <p>A Core Component wrapper that can detect various stages of press interactions on any of its defined children</p> |
Contributor
There was a problem hiding this comment.
I love the idea of highlighting this component, but perhaps the verbiage could lead someone astray (what is a Core Component, is that another component we should be aware of?) Instead, I would slightly adjust the first half of the sentence to read:
Suggested change
| <p>A Core Component wrapper that can detect various stages of press interactions on any of its defined children</p> | |
| <p>A wrapper component that can detect various stages of press interactions on any of its children</p> |
Collaborator
|
Hey @aymenhamada, thanks for the contribution! 👍 Since the PR has not been updated according to the requested changes for a while, closing it in favour of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces documentation for the
Pressablecomponent within the User Interface components section alongsideButtonandSwitch.Changes:
components-and-apis.mdfile to include a section on thePressablecomponent.Resolves: #4022