Skip to content

Add supportedPlatforms=ios,android to SnackPlayer in animations.md#4739

Closed
kaseken wants to merge 1 commit into
react:mainfrom
kaseken:patch-animations
Closed

Add supportedPlatforms=ios,android to SnackPlayer in animations.md#4739
kaseken wants to merge 1 commit into
react:mainfrom
kaseken:patch-animations

Conversation

@kaseken

@kaseken kaseken commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

issue

The preview for Animated API is not rendered correctly for TypeScript+Web.
https://reactnative.dev/docs/animations

This is because useAnimatedValue is undefined in react-native on Web.

Changes

Sets supportedPlatforms=ios,android to SnackPlayer in animations.md since web is not supported.
It was already set for the ext=js version.

before after
スクリーンショット 2025-08-19 19 47 10 スクリーンショット 2025-08-19 19 48 32

- Set supportedPlatforms=ios,android to SnackPlayer in animations.md since web is not supported.
@meta-cla

meta-cla Bot commented Aug 19, 2025

Copy link
Copy Markdown

Hi @kaseken!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@kaseken

kaseken commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

I've signed to the CLA

@netlify

netlify Bot commented Aug 19, 2025

Copy link
Copy Markdown

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit ead74a8
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/68a4582f29644b00088224d2
😎 Deploy Preview https://deploy-preview-4739--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla

meta-cla Bot commented Aug 19, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Aug 19, 2025
@Simek

Simek commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

Hey @kaseken, thanks for the contribution! 👍

I have fixed the examples to work on the web within:

The problem here is that 0.81 docs cut did not include those changes. For now you can use "Next" (unversioned docs), or docs for older version, but we plan to regenerate 0.81 docs soon, to include all recent improvements.

@kaseken

kaseken commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

@Simek Understood, thanks!

@kaseken kaseken closed this Aug 20, 2025
@kaseken kaseken deleted the patch-animations branch August 20, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants