Skip to content

Initial docs for globals#4785

Merged
rubennorte merged 1 commit into
react:mainfrom
rubennorte:globals
Sep 9, 2025
Merged

Initial docs for globals#4785
rubennorte merged 1 commit into
react:mainfrom
rubennorte:globals

Conversation

@rubennorte

@rubennorte rubennorte commented Sep 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This adds placeholder docs for globals, in a new section under the APIs page:

Screenshot 2025-09-09 at 18 51 47

@meta-cla meta-cla Bot added the CLA Signed label Sep 9, 2025
@netlify

netlify Bot commented Sep 9, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 72094ad
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/68c069c028289b0008f18fff
😎 Deploy Preview https://deploy-preview-4785--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Simek

Simek commented Sep 9, 2025

Copy link
Copy Markdown
Collaborator

We currently use "🚧" emoji to indicate deprecated components/APIs.

Screenshot 2025-09-09 at 19 03 56

Recently, we started to annotate experimental pages with "⚗️" emoji, maybe this would fit better for the WIP pages?

Screenshot 2025-09-09 at 19 05 14

Simek
Simek reviewed Sep 9, 2025
View reviewed changes
Comment thread website/sidebars.ts Outdated
@rubennorte

rubennorte commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

We currently use "🚧" emoji to indicate deprecated components/APIs.

That's an unfortunate use of that emoji. Maybe we should reconsider that and use 🗑️ for deprecated ones, as MDN does:

Screenshot 2025-09-09 at 18 28 19

@rubennorte rubennorte force-pushed the globals branch 2 times, most recently from 9c70e24 to 9a0a01d Compare September 9, 2025 17:48
@rubennorte

rubennorte commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

@Simek we changed the existing pages for deprecated APIs to use the 🗑️ emoji and moved the 🚧 emoji to the banner instead of in the title in these cases.

@rubennorte rubennorte marked this pull request as ready for review September 9, 2025 17:55
rickhanlonii
rickhanlonii approved these changes Sep 9, 2025
View reviewed changes

@rickhanlonii rickhanlonii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubennorte rubennorte merged commit 6072161 into react:main Sep 9, 2025
4 checks passed
@rubennorte rubennorte deleted the globals branch September 9, 2025 18:02
@Simek

Simek commented Sep 9, 2025

Copy link
Copy Markdown
Collaborator

@rubennorte Yup, that's a good idea, I like it! 👍

We also use "❌" emoji for the deleted/removed parts from the core, which still had a pages avaible on the website, and with "🗑️" emoji we can still retain this distinction.

@rubennorte rubennorte mentioned this pull request Sep 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Simek Simek Simek left review comments

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@lunaleaps lunaleaps Awaiting requested review from lunaleaps

@cortinico cortinico Awaiting requested review from cortinico

@mattcarrollcode mattcarrollcode Awaiting requested review from mattcarrollcode

@cipolleschi cipolleschi Awaiting requested review from cipolleschi

Assignees

No one assigned

Labels

CLA Signed p: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rubennorte @Simek @rickhanlonii @facebook-github-bot