fix: turbo modules with swift @objc annotation#4862
Merged
Conversation
Contributor
Author
|
cc: @cipolleschi |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
Hey @okwasniewski, thanks for the updates! 👍 Can you also backport changes to the versioned docs? |
Contributor
Author
|
Hey @Simek fixed! |
Simek
approved these changes
Nov 5, 2025
Simek
left a comment
Simek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the update! It seems like a nice improvement and should be safe, let's ship it! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant @objc annotation and replaces it with
@objcMemberswhich exposes all members to Objective-C.