Fixes end of "Handling Text Input" to improve doc flow#4896
Conversation
|
Hi @chris-barile! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Simek
left a comment
Simek
left a comment
There was a problem hiding this comment.
Hey @chris-barile, thanks for proposing the changes! 👍
Left two small formatting/wording suggestions below, before we can ship this. Please also apply them to the versioned doc.
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Adds spaces to ends of files
|
Thanks for the feedback, @Simek. Changes applied to both files. |
Simek
left a comment
Simek
left a comment
There was a problem hiding this comment.
Thanks for the updates, LGTM! 👍
2 participants
The documents in the basic section reference each other sequentially, except for "Handling Text Input". This was mentioned a while back in #2498, but wasn't revisited.
Compare these two examples that show the pattern:
With this one:
As a reader, it's confusing and gives a sense of discontinuity when they're trying to work through the basic documentation to get started in react native.
This PR updates the ending text on that page to still indicate the other relevant documentation, but to maintain the continuity for the reader:
The change is added to the current version of docs as well as the next version.