Remove outdated Objective-C splash screen setup instructions#4911
Conversation
Remove the Objective-C code snippet for handling splash screen transitions from the "Publishing to Apple App Store" documentation. Since React Native 0.71+, new projects generate `AppDelegate.swift` by default, making the Objective-C code referencing `AppDelegate.m` and `[self.window makeKeyAndVisible]` incompatible with modern projects. The `LaunchScreen.storyboard` typically handles the splash screen automatically for most use cases, and developers experiencing the white flash issue should consider using community libraries like `react-native-bootsplash` which have proper Swift support. Fixes react#4770
|
Hi @joshkeldam! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Hey @joshkeldam, thanks for the follow up on issue and providing a context for the change, LGTM! 👍
Refs:
2 participants
Summary
Motivation
Since React Native 0.71+, new projects generate
AppDelegate.swiftby default. The existing Objective-C code referencingAppDelegate.mand[self.window makeKeyAndVisible]is incompatible with Swift-based AppDelegate files and causes confusion for developers.The
LaunchScreen.storyboardhandles splash screens automatically for most use cases. Developers experiencing the white flash issue can use community libraries like react-native-bootsplash which have proper Swift support.Test plan
Fixes #4770