docs: use the correct callback function for RCTMyCustomView onChange#4933
Conversation
…prop pass the local onChange wrapper so that it can extract the nativeEvent.message before calling the parent's props.onChangeMessage
|
Hi @dev-shady! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hey @dev-shady, thanks for the correction! 👍 Can you also apply the change to unversioned doc, and rest of the versioned files? |
|
@Simek Sure, let me update. |
|
@Simek updated. pls check. |
Simek
left a comment
There was a problem hiding this comment.
Thanks for the follow up, LGTM! 👍
pass the local onChange wrapper so that it can extract the nativeEvent.message before calling the parent's props.onChangeMessage