fix plugins TS setup and tests, update workflow#4962
Merged
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Simek
changed the title
cortinico
approved these changes
Jan 13, 2026
Comment on lines
+39
to
+49
| - name: Run remark-codeblock-language-as-title plugin checks | ||
| working-directory: plugins/remark-codeblock-language-as-title | ||
| run: yarn tsc | ||
|
|
||
| - name: Run remark-lint-no-dead-urls plugin checks | ||
| working-directory: plugins/remark-lint-no-dead-urls | ||
| run: yarn tsc && yarn test | ||
|
|
||
| - name: Run remark-snackplayer plugin checks | ||
| working-directory: plugins/remark-snackplayer | ||
| run: yarn tsc && yarn test |
Contributor
There was a problem hiding this comment.
nit: ideally we should have a script in the workspace package.json that takes care of tihs, rather than having to explicitely call yarn tsc and yarn test from the GH workflow
Collaborator
Author
There was a problem hiding this comment.
Good idea, will follow up on that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tried to run
lintcommand inside one of plugins and spotted that the setup is broken and outputs errors.Refs:
How
Replace unresolved TS config for React Native apps with manually defined one for Node + DOM. Fix incorrect paths in tests imports, migrate
remark-lint-no-dead-urlstots-jest, so it can parse correctly the plugin file. Add missingdata-snack-device-appearanceattribute in Snack plugin tape output.I have also added the plugin checks to the CI pre-merge workflow to make sure we catch any issues with plugins earlier in the future.
Test plan
I have run
yarn lintandyarn testin all plugin files, and made sure that all commands are not erroring out, and tests are passing.