Rename TurboModuleManagerDelegate to TurboModuleProvider (#54390)

Summary:
Pull Request resolved: #54390

Simplify the concepts used. These are provider methods for TurboModules, nothing more.

Changelog: [Internal]

Reviewed By: shwanton

Differential Revision: D85052393

fbshipit-source-id: 7f972b211196d12156dfd9aa8890d8f7251cdd57

Author: javache

…/react/nativemodule/TurboModuleManager.h …react/nativemodule/TurboModuleProvider.hpackages/react-native/ReactCxxPlatform/react/nativemodule/TurboModuleManager.h renamed to packages/react-native/ReactCxxPlatform/react/nativemodule/TurboModuleProvider.h packages/react-native/ReactCxxPlatform/react/nativemodule/TurboModuleManager.h renamed to packages/react-native/ReactCxxPlatform/react/nativemodule/TurboModuleProvider.h

@@ -9,15 +9,16 @@
 
 #include <ReactCommon/CallInvoker.h>
 #include <ReactCommon/TurboModule.h>
+
 #include <functional>
 #include <string>
 #include <vector>
 
 namespace facebook::react {
 
-using TurboModuleManagerDelegate =
+using TurboModuleProvider =
     std::function<std::shared_ptr<TurboModule>(const std::string &name, const std::shared_ptr<CallInvoker> &jsInvoker)>;
 
-using TurboModuleManagerDelegates = std::vector<TurboModuleManagerDelegate>;
+using TurboModuleProviders = std::vector<TurboModuleProvider>;
 
 } // namespace facebook::react

packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.cpp

@@ -60,7 +60,7 @@ struct ReactInstanceData {
   JsErrorHandler::OnJsError onJsError;
   Logger logger;
   std::shared_ptr<IDevUIDelegate> devUIDelegate;
-  TurboModuleManagerDelegates turboModuleManagerDelegates;
+  TurboModuleProviders turboModuleProviders;
   std::shared_ptr<SurfaceDelegate> logBoxSurfaceDelegate;
   std::shared_ptr<NativeAnimatedNodesManagerProvider>
       animatedNodesManagerProvider;
@@ -75,7 +75,7 @@ ReactHost::ReactHost(
     JsErrorHandler::OnJsError onJsError,
     Logger logger,
     std::shared_ptr<IDevUIDelegate> devUIDelegate,
-    TurboModuleManagerDelegates turboModuleManagerDelegates,
+    TurboModuleProviders turboModuleProviders,
     std::shared_ptr<SurfaceDelegate> logBoxSurfaceDelegate,
     std::shared_ptr<NativeAnimatedNodesManagerProvider>
         animatedNodesManagerProvider,
@@ -92,7 +92,7 @@ ReactHost::ReactHost(
       .onJsError = std::move(onJsError),
       .logger = std::move(logger),
       .devUIDelegate = devUIDelegate,
-      .turboModuleManagerDelegates = std::move(turboModuleManagerDelegates),
+      .turboModuleProviders = std::move(turboModuleProviders),
       .logBoxSurfaceDelegate = logBoxSurfaceDelegate,
       .animatedNodesManagerProvider = animatedNodesManagerProvider,
       .bindingsInstallFunc = std::move(bindingsInstallFunc)});
@@ -259,18 +259,16 @@ void ReactHost::createReactInstance() {
   reactInstance_->initializeRuntime(
       {
 #if defined(WITH_PERFETTO) || defined(RNCXX_WITH_PROFILING_PROVIDER)
-          .isProfiling = true
+          .isProfiling = true,
 #else
-          .isProfiling = false
+          .isProfiling = false,
 #endif
-          ,
           .runtimeDiagnosticFlags = ""},
       [weakMountingManager =
            std::weak_ptr<IMountingManager>(reactInstanceData_->mountingManager),
        logger = reactInstanceData_->logger,
        devUIDelegate = reactInstanceData_->devUIDelegate,
-       turboModuleManagerDelegates =
-           reactInstanceData_->turboModuleManagerDelegates,
+       turboModuleProviders = reactInstanceData_->turboModuleProviders,
        jsInvoker = std::move(jsInvoker),
        logBoxSurfaceDelegate = reactInstanceData_->logBoxSurfaceDelegate,
        devServerHelper =
@@ -297,7 +295,7 @@ void ReactHost::createReactInstance() {
             });
 
         auto turboModuleProvider =
-            [turboModuleManagerDelegates,
+            [turboModuleProviders,
              jsInvoker,
              logBoxSurfaceDelegate,
              devServerHelper,
@@ -311,11 +309,9 @@ void ReactHost::createReactInstance() {
           react_native_assert(
               !name.empty() && "TurboModule name must not be empty");
 
-          for (const auto& turboModuleManagerDelegate :
-               turboModuleManagerDelegates) {
-            if (turboModuleManagerDelegate) {
-              if (auto turboModule =
-                      turboModuleManagerDelegate(name, jsInvoker)) {
+          for (const auto& turboModuleProvider : turboModuleProviders) {
+            if (turboModuleProvider) {
+              if (auto turboModule = turboModuleProvider(name, jsInvoker)) {
                 return turboModule;
               }
             }

packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.h

@@ -14,7 +14,7 @@
 #include <cxxreact/MessageQueueThread.h>
 #include <react/logging/DefaultLogger.h>
 #include <react/nativemodule/JavaScriptModule.h>
-#include <react/nativemodule/TurboModuleManager.h>
+#include <react/nativemodule/TurboModuleProvider.h>
 #include <react/renderer/scheduler/Scheduler.h>
 #include <react/runtime/ReactInstance.h>
 #include <react/utils/RunLoopObserverManager.h>
@@ -48,7 +48,7 @@ class ReactHost {
       JsErrorHandler::OnJsError onJsError,
       Logger logger,
       std::shared_ptr<IDevUIDelegate> devUIDelegate = nullptr,
-      TurboModuleManagerDelegates turboModuleManagerDelegates = {},
+      TurboModuleProviders turboModuleProviders = {},
       std::shared_ptr<SurfaceDelegate> logBoxSurfaceDelegate = nullptr,
       std::shared_ptr<NativeAnimatedNodesManagerProvider> animatedNodesManagerProvider = nullptr,
       ReactInstance::BindingsInstallFunc bindingsInstallFunc = nullptr);

private/react-native-fantom/tester/src/TesterAppDelegate.cpp

@@ -8,7 +8,7 @@
 #include "TesterAppDelegate.h"
 
 #include "NativeFantom.h"
-#include "platform/TesterTurboModuleManagerDelegate.h"
+#include "platform/TesterTurboModuleProvider.h"
 #include "stubs/StubClock.h"
 #include "stubs/StubHttpClient.h"
 #include "stubs/StubQueue.h"
@@ -88,7 +88,7 @@ TesterAppDelegate::TesterAppDelegate(
 
   runLoopObserverManager_ = std::make_shared<RunLoopObserverManager>();
 
-  TurboModuleManagerDelegates turboModuleProviders{
+  TurboModuleProviders turboModuleProviders{
       [&](const std::string& name,
           const std::shared_ptr<CallInvoker>& jsInvoker)
           -> std::shared_ptr<TurboModule> {
@@ -105,7 +105,7 @@ TesterAppDelegate::TesterAppDelegate(
           return nullptr;
         }
       },
-      TesterTurboModuleManagerDelegate::getTurboModuleManagerDelegate()};
+      TesterTurboModuleProvider::getTurboModuleProvider()};
 
   g_setNativeAnimatedNowTimestampFunction(StubClock::now);
 

…tform/TesterTurboModuleManagerDelegate.h …src/platform/TesterTurboModuleProvider.hprivate/react-native-fantom/tester/src/platform/TesterTurboModuleManagerDelegate.h renamed to private/react-native-fantom/tester/src/platform/TesterTurboModuleProvider.h private/react-native-fantom/tester/src/platform/TesterTurboModuleManagerDelegate.h renamed to private/react-native-fantom/tester/src/platform/TesterTurboModuleProvider.h

@@ -7,11 +7,11 @@
 
 #pragma once
 
-#include <react/nativemodule/TurboModuleManager.h>
+#include <react/nativemodule/TurboModuleProvider.h>
 
 namespace facebook::react {
-class TesterTurboModuleManagerDelegate {
+class TesterTurboModuleProvider {
  public:
-  static TurboModuleManagerDelegate getTurboModuleManagerDelegate();
+  static TurboModuleProvider getTurboModuleProvider();
 };
 } // namespace facebook::react

…eta/TesterTurboModuleManagerDelegate.cpp …tform/meta/TesterTurboModuleProvider.cppprivate/react-native-fantom/tester/src/platform/meta/TesterTurboModuleManagerDelegate.cpp renamed to private/react-native-fantom/tester/src/platform/meta/TesterTurboModuleProvider.cpp private/react-native-fantom/tester/src/platform/meta/TesterTurboModuleManagerDelegate.cpp renamed to private/react-native-fantom/tester/src/platform/meta/TesterTurboModuleProvider.cpp

@@ -4,14 +4,13 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  */
-
-#include "../TesterTurboModuleManagerDelegate.h"
+#include "../TesterTurboModuleProvider.h"
 #include <NativeCxxModuleExample/NativeCxxModuleExample.h>
 
 namespace facebook::react {
-/* static */ TurboModuleManagerDelegate
-TesterTurboModuleManagerDelegate::getTurboModuleManagerDelegate() {
-  return TurboModuleManagerDelegate{
+/* static */ TurboModuleProvider
+TesterTurboModuleProvider::getTurboModuleProvider() {
+  return TurboModuleProvider{
       [](const std::string& name, const std::shared_ptr<CallInvoker>& jsInvoker)
           -> std::shared_ptr<TurboModule> {
         if (name == NativeCxxModuleExample::kModuleName) {

…oss/TesterTurboModuleManagerDelegate.cpp …atform/oss/TesterTurboModuleProvider.cppprivate/react-native-fantom/tester/src/platform/oss/TesterTurboModuleManagerDelegate.cpp renamed to private/react-native-fantom/tester/src/platform/oss/TesterTurboModuleProvider.cpp private/react-native-fantom/tester/src/platform/oss/TesterTurboModuleManagerDelegate.cpp renamed to private/react-native-fantom/tester/src/platform/oss/TesterTurboModuleProvider.cpp

@@ -5,12 +5,12 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#include "../TesterTurboModuleManagerDelegate.h"
+#include "../TesterTurboModuleProvider.h"
 
 namespace facebook::react {
-/* static */ TurboModuleManagerDelegate
-TesterTurboModuleManagerDelegate::getTurboModuleManagerDelegate() {
-  return TurboModuleManagerDelegate{
+/* static */ TurboModuleProvider
+TesterTurboModuleProvider::getTurboModuleProvider() {
+  return TurboModuleProvider{
       [](const std::string& name, const std::shared_ptr<CallInvoker>& jsInvoker)
           -> std::shared_ptr<TurboModule> { return nullptr; }};
 }