Skip to content

[precompile] added readme/doc files for precompile#54137

Closed
chrfalch wants to merge 14 commits into
mainfrom
chrfalch/added-simple-readme-files-for-prebuild
Closed

[precompile] added readme/doc files for precompile#54137
chrfalch wants to merge 14 commits into
mainfrom
chrfalch/added-simple-readme-files-for-prebuild

Conversation

@chrfalch

Copy link
Copy Markdown
Collaborator

Summary:

Added readme files for both RN dependencies and RN Core precompiled

Changelog:

[IOS] [FIXED] - Added documentation for the prebuild scripts for precompiling React Native Core and React Native Dependencies.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
@chrfalch chrfalch requested a review from cipolleschi October 13, 2025 08:05
@react-native-bot

react-native-bot commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator
Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a9d30e1

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 13, 2025
@meta-codesync

meta-codesync Bot commented Oct 13, 2025

Copy link
Copy Markdown

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D84506769.

@cipolleschi cipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrfalch Amazing job with the docs! Thanks for working on them.

I left some comments that should improve them.

Before submitting, try to run yarn prettier as we have sevarl prettier warnings popping up!

Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md
Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md Outdated
Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md Outdated
Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md Outdated
Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md Outdated
Comment thread scripts/releases/ios-prebuild/__docs__/README.md Outdated
Comment thread scripts/releases/ios-prebuild/__docs__/README.md Outdated
Comment thread scripts/releases/ios-prebuild/__docs__/README.md Outdated
Comment thread scripts/releases/ios-prebuild/__docs__/README.md Outdated
Comment thread scripts/releases/ios-prebuild/__docs__/README.md Outdated
@chrfalch chrfalch requested a review from cipolleschi October 14, 2025 13:07
@chrfalch

Copy link
Copy Markdown
Collaborator Author

Hey @chrfalch Amazing job with the docs! Thanks for working on them.

I left some comments that should improve them.

Before submitting, try to run yarn prettier as we have sevarl prettier warnings popping up!

Made them both simpler, also changed here and there and aligned the structure a bit better.

@cipolleschi cipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some other suggestions for changes. There are a couple of wrong things and we need to fix the formatting, but otherwise it will be good to go.

Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md
Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md
Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md Outdated
Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md Outdated
Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md Outdated
Comment thread scripts/releases/ios-prebuild/__docs__/README.md
Comment thread scripts/releases/ios-prebuild/__docs__/README.md
Comment thread scripts/releases/ios-prebuild/__docs__/README.md
Comment thread scripts/releases/ios-prebuild/__docs__/README.md
Comment thread packages/react-native/scripts/ios-prebuild/__docs__/README.md
@chrfalch chrfalch requested a review from cipolleschi November 11, 2025 09:36
@chrfalch

Copy link
Copy Markdown
Collaborator Author

Thanks, @cipolleschi, for the input!!

@cortinico

Copy link
Copy Markdown
Contributor

/rebase

@cortinico

Copy link
Copy Markdown
Contributor

@chrfalch can we make sure the CI for this one is green before I import it again?

chrfalch and others added 12 commits November 19, 2025 18:06
Added readme files for both RN dependencies and RN Core precompiled
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
@cortinico cortinico force-pushed the chrfalch/added-simple-readme-files-for-prebuild branch from 99bba7d to 6fff738 Compare November 19, 2025 18:06
@meta-codesync meta-codesync Bot closed this in 7a66582 Nov 20, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 20, 2025
@meta-codesync

meta-codesync Bot commented Nov 20, 2025

Copy link
Copy Markdown

@cortinico merged this pull request in 7a66582.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @chrfalch in 7a66582

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants