[precompile] added readme/doc files for precompile#54137
Conversation
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D84506769. |
cipolleschi
left a comment
There was a problem hiding this comment.
Hey @chrfalch Amazing job with the docs! Thanks for working on them.
I left some comments that should improve them.
Before submitting, try to run yarn prettier as we have sevarl prettier warnings popping up!
Made them both simpler, also changed here and there and aligned the structure a bit better. |
cipolleschi
left a comment
There was a problem hiding this comment.
Left some other suggestions for changes. There are a couple of wrong things and we need to fix the formatting, but otherwise it will be good to go.
|
Thanks, @cipolleschi, for the input!! |
|
/rebase |
|
@chrfalch can we make sure the CI for this one is green before I import it again? |
Added readme files for both RN dependencies and RN Core precompiled
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
Co-authored-by: Riccardo Cipolleschi <cipolleschi@meta.com>
99bba7d to
6fff738
Compare
|
@cortinico merged this pull request in 7a66582. |
|
This pull request was successfully merged by @chrfalch in 7a66582 When will my fix make it into a release? | How to file a pick request? |
Summary:
Added readme files for both RN dependencies and RN Core precompiled
Changelog:
[IOS] [FIXED] - Added documentation for the prebuild scripts for precompiling React Native Core and React Native Dependencies.