Skip to content

[RN][iOS] Fix Dynamic framework build and resolve circular dependency for JSC#54421

Closed
cipolleschi wants to merge 1 commit into
mainfrom
cipolleschi/fix-dyn-frameworks-and-circ-dep
Closed

[RN][iOS] Fix Dynamic framework build and resolve circular dependency for JSC#54421
cipolleschi wants to merge 1 commit into
mainfrom
cipolleschi/fix-dyn-frameworks-and-circ-dep

Conversation

@cipolleschi

Copy link
Copy Markdown
Contributor

Summary:

OSS community shared with me that we have a circular dependency in React-utils.podspec that prevent them from building with JSC.
While fixing it, I realized that the dynamic framework build was broken. So I fixed them both.

Changelog:

[iOS][Fixed] - Fixed build with dynamic frameworks

Test Plan:

Build RNTester locally with USE_FRAMEWORKS=dynamic

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2025
@meta-codesync

meta-codesync Bot commented Nov 5, 2025

Copy link
Copy Markdown

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D86309592.

@meta-codesync

meta-codesync Bot commented Nov 5, 2025

Copy link
Copy Markdown

@cipolleschi merged this pull request in 1033dbd.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 5, 2025
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cipolleschi in 1033dbd

When will my fix make it into a release? | How to file a pick request?

react-native-bot pushed a commit that referenced this pull request Nov 10, 2025
…54421)

Summary:
OSS community shared with me that we have a circular dependency in React-utils.podspec that prevent them from building with JSC.
While fixing it, I realized that the dynamic framework build was broken. So I fixed them both.

## Changelog:
[iOS][Fixed] - Fixed build with dynamic frameworks

Pull Request resolved: #54421

Test Plan: Build RNTester locally with USE_FRAMEWORKS=dynamic

Reviewed By: javache

Differential Revision: D86309592

Pulled By: cipolleschi

fbshipit-source-id: f2995332ae135ce951480b353df7d597ff8a85ec
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cipolleschi in 175b7f9

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants