Split families by surfaceId in Animation Backend#54424
Closed
bartlomiejbloniarz wants to merge 3 commits into
Closed
Split families by surfaceId in Animation Backend#54424bartlomiejbloniarz wants to merge 3 commits into
bartlomiejbloniarz wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84055753. |
Job Summary for GradleTest All :: run_fantom_tests
|
facebook-github-bot
force-pushed
the
export-D84055753
branch
2 times, most recently
from
a7304ea to
6ef45ad
Compare
facebook-github-bot
force-pushed
the
export-D84055753
branch
from
6ef45ad to
a7304ea
Compare
added 3 commits
November 6, 2025 02:51
Summary: Withouth the backend, Animated triggers the start function once per frame (by updating an atomic bool). We now do the same with animation backend. Reviewed By: zeyap Differential Revision: D85234259
Summary: Animation frames on Android are tiggered from UIManagerNativeAnimatedDelegate::runAnimationFrame, so we implement that for the backend Reviewed By: zeyap Differential Revision: D84055754
Summary: AnimationBackend might be handling mulitple surfaces at once, so we need to separate the updates, by `SurfaceId` Reviewed By: zeyap Differential Revision: D84055753
facebook-github-bot
force-pushed
the
export-D84055753
branch
from
a7304ea to
eb3ca72
Compare
|
This pull request has been merged in 5c078bd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: AnimationBackend might be handling mulitple surfaces at once, so we need to separate the updates, by
SurfaceIdReviewed By: zeyap
Differential Revision: D84055753