Start AnimationBackend callbacks once per frame in Animated#54426
Closed
bartlomiejbloniarz wants to merge 1 commit into
Closed
Start AnimationBackend callbacks once per frame in Animated#54426bartlomiejbloniarz wants to merge 1 commit into
bartlomiejbloniarz wants to merge 1 commit into
Conversation
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85234259. |
47d41ca to
17be807
Compare
17be807 to
adf62e8
Compare
adf62e8 to
17be807
Compare
Summary: Withouth the backend, Animated triggers the start function once per frame (by updating an atomic bool). We now do the same with animation backend. Reviewed By: zeyap Differential Revision: D85234259
17be807 to
8949c78
Compare
|
This pull request has been merged in 8b95fce. |
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in 8b95fce When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Withouth the backend, Animated triggers the start function once per frame (by updating an atomic bool). We now do the same with animation backend.
Reviewed By: zeyap
Differential Revision: D85234259