Calll the ShadowNode::cloneMultiple callback for each cloned node#54431
Closed
bartlomiejbloniarz wants to merge 1 commit into
Closed
Calll the ShadowNode::cloneMultiple callback for each cloned node#54431bartlomiejbloniarz wants to merge 1 commit into
bartlomiejbloniarz wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85852143. |
…4431) Summary: The original intention by the cloneMultiple method was to give the possibility of defining the cloning method only for the nodes definied by the list of families. But this way it is impossible to for example set the value of `runtimeShadowNodeReference` in the fragment, so instead we now pass the responsibility of cloning to the user for all the cloned nodes. # Changelog [General] [Changed] - cloneMultiple now invokes the callback for every cloned node, instead of doing that only for the nodes in `familiesToUpdate` Reviewed By: javache Differential Revision: D85852143
facebook-github-bot
force-pushed
the
export-D85852143
branch
from
1b5e20c to
0ec77d8
Compare
|
This pull request has been merged in 976c849. |
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in 976c849 When will my fix make it into a release? | How to file a pick request? |
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Nov 15, 2025
…4431) Summary: Pull Request resolved: react/react-native#54431 The original intention by the cloneMultiple method was to give the possibility of defining the cloning method only for the nodes definied by the list of families. But this way it is impossible to for example set the value of `runtimeShadowNodeReference` in the fragment, so instead we now pass the responsibility of cloning to the user for all the cloned nodes. # Changelog [General] [Changed] - cloneMultiple now invokes the callback for every cloned node, instead of doing that only for the nodes in `familiesToUpdate` Reviewed By: javache Differential Revision: D85852143 fbshipit-source-id: 9cf0540f546f5f070a918b8a4434ad40f78d91f6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The original intention by the cloneMultiple method was to give the possibility of defining the cloning method only for the nodes definied by the list of families. But this way it is impossible to for example set the value of
runtimeShadowNodeReferencein the fragment, so instead we now pass the responsibility of cloning to the user for all the cloned nodes.Changelog
[General] [Changed] - cloneMultiple now invokes the callback for every cloned node, instead of doing that only for the nodes in
familiesToUpdateDifferential Revision: D85852143