Skip to content

[RN][iOS][CI] Restore testing with Cocoapods and use_frameworks#54482

Closed
cipolleschi wants to merge 1 commit into
mainfrom
cipolleschi/restore-dyn-frameworks-tests
Closed

[RN][iOS][CI] Restore testing with Cocoapods and use_frameworks#54482
cipolleschi wants to merge 1 commit into
mainfrom
cipolleschi/restore-dyn-frameworks-tests

Conversation

@cipolleschi

Copy link
Copy Markdown
Contributor

Summary:

After moving to SwiftPM, we stopped testing the build from source using Cocoapods and dynamic frameworks. Given that the migration will take some more time, this change reintroduces a job to keep the build from source using dynamic frameworks in check

Changelog:

[Internal] -

Test Plan:

GHA

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025
@cipolleschi cipolleschi marked this pull request as draft November 10, 2025 18:08
@cipolleschi cipolleschi force-pushed the cipolleschi/restore-dyn-frameworks-tests branch 2 times, most recently from c343381 to 3a62c6c Compare November 11, 2025 11:09
@cipolleschi cipolleschi marked this pull request as ready for review November 11, 2025 11:59
@meta-codesync

meta-codesync Bot commented Nov 11, 2025

Copy link
Copy Markdown

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D86760336.

@cipolleschi cipolleschi force-pushed the cipolleschi/restore-dyn-frameworks-tests branch 3 times, most recently from db6d971 to 1907395 Compare November 11, 2025 16:44
@cipolleschi cipolleschi force-pushed the cipolleschi/restore-dyn-frameworks-tests branch from 1907395 to f1cfe4e Compare November 11, 2025 17:14
@meta-codesync meta-codesync Bot closed this in 1c83c00 Nov 12, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 12, 2025
@meta-codesync

meta-codesync Bot commented Nov 12, 2025

Copy link
Copy Markdown

@cipolleschi merged this pull request in 1c83c00.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cipolleschi in 1c83c00

When will my fix make it into a release? | How to file a pick request?

douglowder pushed a commit to react-native-tvos/react-native-tvos that referenced this pull request Nov 15, 2025
Summary:
After moving to SwiftPM, we stopped testing the build from source using Cocoapods and dynamic frameworks. Given that the migration will take some more time, this change reintroduces a job to keep the build from source using dynamic frameworks in check

## Changelog:
[Internal] -

Pull Request resolved: react/react-native#54482

Test Plan: GHA

Reviewed By: javache

Differential Revision: D86760336

Pulled By: cipolleschi

fbshipit-source-id: c131af44209de40f2ee7f7d08fa61d88aa48d3ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants