Exclude generated code from lint#54530
Closed
Simek wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
cipolleschi
approved these changes
Nov 13, 2025
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D86963479. |
cortinico
approved these changes
Nov 13, 2025
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@cipolleschi merged this pull request in 810f983. |
Collaborator
|
This pull request was successfully merged by @Simek in 810f983 When will my fix make it into a release? | How to file a pick request? |
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Nov 15, 2025
Summary: I was experimenting with TS API in the monorepo, and spotted that root lint tries to format generated code. This small change add exclusion for files in `private/react-native-codegen-typescript-test/lib` which are generated locally when running TS API tests. The path is already ignored in `.gitignore` file: * https://github.com/facebook/react-native/blob/main/.gitignore#L146-L146 ## Changelog: [INTERNAL] [FIXED] - Exclude generated code from lint checks to avoid unnecessary warnings. Pull Request resolved: react/react-native#54530 Test Plan: Running `yarn lint` at monorepo root no longer outputs warnings. Reviewed By: cortinico Differential Revision: D86963479 Pulled By: cipolleschi fbshipit-source-id: e067bbbbf69d24929095aed1145f41ae9f26fbd4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I was experimenting with TS API in the monorepo, and spotted that root lint tries to format generated code.
This small change add exclusion for files in
private/react-native-codegen-typescript-test/libwhich are generated locally when running TS API tests. The path is already ignored in.gitignorefile:Changelog:
[INTERNAL] [FIXED] - Exclude generated code from lint checks to avoid unnecessary warnings.
Test Plan:
Running
yarn lintat monorepo root no longer outputs warnings.